Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate/optimize performance of TrimAnalysisPatterns tracked by ILLink Roslyn analyzer #94312

Open
sbomer opened this issue Nov 2, 2023 · 2 comments
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Milestone

Comments

@sbomer
Copy link
Member

sbomer commented Nov 2, 2023

The ILLink RoslynAnalyzer has various types such as TrimAnalysisMethodCallPattern and TrimAnalysisFieldAccessPattern used to track relevant "patterns" that may produce dataflow warnings. Tracking such values is potentially expensive, especially now that we do it even for values which may not be relevant for dataflow, just to track their types, after #93732.

On top of that, #94123 is introducing additional context to the tracked patterns to track the "feature context" of the invocation/field access/etc.

We should investigate the performance of this approach and consider ways to optimize it.

Context: #94123 (comment)

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 2, 2023
@ghost
Copy link

ghost commented Nov 2, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

The ILLink RoslynAnalyzer has various types such as TrimAnalysisMethodCallPattern and TrimAnalysisFieldAccessPattern used to track relevant "patterns" that may produce dataflow warnings. Tracking such values is potentially expensive, especially now that we do it even for values which may not be relevant for dataflow, just to track their types, after #93732.

We should investigate the performance of this approach and consider ways to optimize it.

Context: #94123 (comment)

Author: sbomer
Assignees: -
Labels:

area-Meta

Milestone: -

@vitek-karas vitek-karas added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Nov 3, 2023
@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

The ILLink RoslynAnalyzer has various types such as TrimAnalysisMethodCallPattern and TrimAnalysisFieldAccessPattern used to track relevant "patterns" that may produce dataflow warnings. Tracking such values is potentially expensive, especially now that we do it even for values which may not be relevant for dataflow, just to track their types, after #93732.

On top of that, #94123 is introducing additional context to the tracked patterns to track the "feature context" of the invocation/field access/etc.

We should investigate the performance of this approach and consider ways to optimize it.

Context: #94123 (comment)

Author: sbomer
Assignees: -
Labels:

area-Meta, untriaged, area-Tools-ILLink

Milestone: -

@agocke agocke added this to the Future milestone Apr 22, 2024
@sbomer sbomer removed the untriaged New issue has not been triaged by the area owner label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
Status: No status
Development

No branches or pull requests

3 participants