Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT-LLVM] Building for Win/Linux fails #1713

Open
yowl opened this issue Nov 10, 2021 · 0 comments
Open

[NativeAOT-LLVM] Building for Win/Linux fails #1713

yowl opened this issue Nov 10, 2021 · 0 comments
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)

Comments

@yowl
Copy link
Contributor

yowl commented Nov 10, 2021

While the branch is aimed to building LLVM/Wasm, it ought to be possible to still build for win-x64 and linux-x64 but attempting to do so fails with

E:\tmp\aot\pkg\microsoft.dotnet.ilcompiler.llvm\7.0.0-dev\build\Microsoft.NETCore.Native.Publish.targets(75,5): error : The PrivateSdkAssemblies ItemGroup is required for _ComputeAssembliesToCompileToNative [E:\tmp\aot\aot.csproj]

This is a similar problem to #260 (comment) , the names are

Message:  PackageDefinitions Microsoft.DotNet.ILCompiler.LLVM/7.0.0-dev PackageDefinitions.Name Microsoft.DotNet.ILCompiler.LLVM RuntimeIlcPackageName runtime.win-x64.Microsoft.DotNet.ILCompiler

and can be worked around by modifying Microsoft.DotNet.ILCompiler.targets to append .LLVM to the package name, for example, just handling both names

      <RuntimePackagePath Condition="'%(PackageDefinitions.Name)' == '$(RuntimeIlcPackageName)'">%(PackageDefinitions.ResolvedPath)</RuntimePackagePath>
      <RuntimePackagePath Condition="'%(PackageDefinitions.Name)' == '$(RuntimeIlcPackageName).LLVM'">%(PackageDefinitions.ResolvedPath)</RuntimePackagePath>
      <IlcHostPackagePath Condition="'%(PackageDefinitions.Name)' == '$(IlcHostPackageName)'">%(PackageDefinitions.ResolvedPath)</IlcHostPackagePath>
      <IlcHostPackagePath Condition="'%(PackageDefinitions.Name)' == '$(IlcHostPackageName).LLVM'">%(PackageDefinitions.ResolvedPath)</IlcHostPackagePath>
@jkotas jkotas added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Development

No branches or pull requests

2 participants