Swap to OS thread for special cases #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- where we don't use an FCall or standard P/Invoke transition to go to C++ code - Do so by generalizing the C++ lambda technique used for the FCall transitions and make it available as a macro for these other transitions to use Fixes dotnet#2051
markples
reviewed
Nov 2, 2022
Comment on lines
+607
to
+609
| RETURN; | ||
| END_ENSURE_ON_OS_THREAD(); | ||
| return retAddr; |
There was a problem hiding this comment.
Sorry for the late review - why does only this one have RETURN + return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2051