-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stream boilerplate source-generator and attribute #2185
Merged
Jozkee
merged 30 commits into
dotnet:feature/stream-sourcegen
from
Jozkee:feature/stream-sourcegen
Dec 12, 2023
Merged
Add Stream boilerplate source-generator and attribute #2185
Jozkee
merged 30 commits into
dotnet:feature/stream-sourcegen
from
Jozkee:feature/stream-sourcegen
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code changes for flexible generation
Jozkee
changed the title
Initial comit for Stream boilerplate source-gen
Add Stream boilerplate source-generator and attribute
Feb 13, 2023
2 tasks
bartonjs
added
* NO MERGE *
The PR is not ready for merge yet (see discussion for detailed reasons)
and removed
* NO MERGE *
The PR is not ready for merge yet (see discussion for detailed reasons)
labels
Feb 14, 2023
bartonjs
reviewed
Feb 14, 2023
src/System.IO.StreamSourceGeneration/src/BoilerplateCandidateInfo.cs
Outdated
Show resolved
Hide resolved
src/System.IO.StreamSourceGeneration/src/BoilerplateCandidateInfo.cs
Outdated
Show resolved
Hide resolved
src/System.IO.StreamSourceGeneration/src/GenerateStreamBoilerplateAttribute.cs
Outdated
Show resolved
Hide resolved
src/System.IO.StreamSourceGeneration/src/GenerateStreamBoilerplateAttribute.cs
Outdated
Show resolved
Hide resolved
src/System.IO.StreamSourceGeneration/src/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
src/System.IO.StreamSourceGeneration/src/System.IO.StreamSourceGeneration.csproj
Outdated
Show resolved
Hide resolved
Ping @stephentoub @bartonjs, this is ready for re-review. |
… by read AND write missing
Ping @stephentoub. I'm planning on adding tests to ensure we emit the proper diagnostics, functional tests checking the behavior of the generated code already exists. In the meantime, this PR could benefit from a code review. |
stephentoub
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from https://github.com/dotnet/runtimelab/tree/standalone-template.
Adds the
System.IO.StreamSourceGeneration
project containing the generator and the[GenerateStreamBoilerplate]
attribute.Adds test verifying generation of a variety of streams that implement one or more members that can be used to hint to the generator what it should do:
StreamThatImplementsNothing
StreamThatImplementsReadAsyncByte
StreamThatImplementsReadAsyncMemory
StreamThatImplementsReadByte
StreamThatImplementsReadSpan
StreamThatImplementsSeek
StreamThatImplementsWriteAsyncByte
StreamThatImplementsWriteAsyncMemory
StreamThatImplementsWriteByte
StreamThatImplementsWriteSpan
This PR does not add, but is intended as a foundation for adding analyzer rules that hint the user about potential improvements on their Stream implementation. e.g: "Prefer overriding Span/Memory overloads instead of calling byte[] ones."