* Make Common.Tests pass

* Remove Common test project from the exclusion list

* add TargetHostName to SslStream

* fix unit tests

* feedback from review

* move the interface check to be before versionbubble

* updating fix to check for TypicalMethod of the target

* Adding a comment to clarify the check

* uncoditinoally invoke GetTypicalMethodDef

* Add a smoke test.

* moving the interface check to before version bubble

Also adding a cross module test.

- Mimic the alignment and other algorithms present in coreclr
- Add tests to crossgen2smoke to cover these scenarios
- Update type system unit tests so that they can run in VS
- Fix issue #38450

* Add platform-specific attributes

Spec dotnet/runtime#33331

* Convert to xml doc

* Update src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/MinimumOSAttribute.cs

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>

* Update src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ObsoletedInPlatformAttribute.cs

Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>

* Address code review

* Add to ref assembly, test and fix build errors

* Fix spacing, revert unwanted changes

* Namespace was wrong, updated

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>

* add two SslStream tests for custom validation

* use BuildPrivatePki

* feedback from review

* disable on windows

* Align SpecializeComparer with ComparerHelpers

* Align SpecializeEqualityComparer with ComparerHelpers

…38578)

* Turn on argument exception analyzer on runtime, fix failures found

Fix interpreter build

Add PAL_GetApplicationGroupId() that returns null for Linux.

* initial support for SslStreamCertificateContext

* update openssl pal

* feedback from review

* fix unit tests

* fix platforms

* update ref

…… (#38655)

* [browser][wasm][bindings] Handle case where AsyncStateMachineBox`1 is returned

- There are cases where AsyncStateMachineBox`1 is returned instead of instead of Task`1 within the bindings.  This was causing exceptions with Promise processing.

* Use `is_subclass_of` instead of strings to recognize Tasks

This can by used by the xharness xunit runner to make sure async tasks are executed.

We also need to tweak how `ThreadPoolTaskScheduler` handles `TaskCreationOptions.LongRunning` since the usual mode of starting a new thread doesn't work, instead we treat it like the option wasn't set and queue the task on the threadpool.

…8674)

Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>

…tAndInsert (#38680)

* Implements InsertScalar 

* Uses InsertScalar to implement Vector128<T>.WithLower() and Vector128<T>.WithUpper()

* Renames ShiftLeftLogicalAndInsert to ShiftLeftAndInsert and ShiftRightLogicalAndInsert to ShiftRightAndInsert

Contributes to mono/mono#15142

+ When allocating in UOH free list we should do >= (min_obj_size) instead of >.
+ Renamed loh_a_fit_segment_end_p to uoh_a_fit_segment_end_p (should have been part of the refactoring work)

* [browser][wasm] Initial addition of WebSockets support

* Clean up usings

* Create and use a WebSocketHandle.Browser.cs module

* Add conditional TARGETS_BROWSER so as not to throw Proxy PNSE during ClientWebSocket creation.

* Update WebSockets code

* Removing debug line

* Remove `ThrowIfReadOnly` method to address review comments

* Address review comments

- change accessor of _requestedSubProtocols to private
- condition more code in WebSocketHandle.Managed.cs to not access _requestedSubProtocols

* Address review comments

* Address review comments

* Change to be PlatformNotSupportedException

* Add ConnectAsync implementation to create a new instance of the BrowserWebSocket implementation.

* Address review comments

* Address subprotocols comments

* Remove internal custom class ActionQueue class in favor of using a Channel.

* Fix object leak.

- Lambdas are not being released automatically.

* Add doc for the constant that is being used.

- Address review comment

* Clean up SendAsync method.

- Validate the message type.
- Validate the array segment that is passed as the message.

* Add validation to ReceiveAsync for invalid buffer.

- remove unnecessary null checks from message buffering.

* Address review comments

* Address review comments about TCS

* Address camel case by using enum

* Address abort request

* Handle nullable

* Address review comment for removing cancellationtoken registration to the connect source.

* Use non-generic TaskCompletionSource

* Cleanup var usage

* Add string to .resx

* Inline dispose

* Fix WebSocket opening exception

* Remove the asynchronous completion from SendAsync.

* Fix object leak, exception on close and address review comments

* Handle race condition

* Address 	TaskCompletionSource on connect review comments

* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: campersau <buchholz.bastian@googlemail.com>

* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: campersau <buchholz.bastian@googlemail.com>

* Fix Connect not completing task on error.

* Cleanup reference

* Remove redundant error check of memorystream buffer.

* cleanup

* Update src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj

Co-authored-by: Maxim Lipnin <mlipnin@gmail.com>

* Update src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj

Co-authored-by: Maxim Lipnin <mlipnin@gmail.com>

* Update src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj

Co-authored-by: Maxim Lipnin <mlipnin@gmail.com>

* Update src/libraries/System.Net.WebSockets.Client/src/System.Net.WebSockets.Client.csproj

Co-authored-by: Maxim Lipnin <mlipnin@gmail.com>

* Fix typo

* clean up buffer code

* Modify callbacks to use lambda function.

- These are now released properly after reference counting went in.

* Fix object leak of delegate and clean up deprecated code.

* extract lambda into method

* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Review comments addressed

Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Co-authored-by: Maxim Lipnin <mlipnin@gmail.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>

…(#38695)

* Added doc with instructions on running basic ASP.NET Benchmarks with crossgen2.

* Shortened clr+libs command in Asp.Net Benchmarks doc.

…H segments and objects in ICorDebug (#38146)

* Respect new MD bit in runtime

* Throw "not implemented".

* Update parser for ILAsm
Add text based grammar file for IL tooling

* Update ILDasm

* Add disabled test project for function pointers.

* Add feature detection.

* Enable ilasm/ildasm round trip testing in new AzDO pipeline

Pipeline is `runtime-coreclr ilasm`.

Also, add an optional `IlasmRoundTripIncompatible` msbuild
property to allow disabling tests for the IlasmRoundTrip test.

* Disable tests for ilasm round-trip testing

Tracking issues:
dotnet/runtime#11412
dotnet/runtime#38515
dotnet/runtime#38506
dotnet/runtime#38507
dotnet/runtime#38508
dotnet/runtime#38529

With the recent async Tasks fix we can now skip just a handful of tests to get the testsuite to passing: `Tests run: 317, Errors: 0, Failures: 0, Skipped: 18. Time: 18.780363s`

When a BatchBlock is marked for completion, it will no longer consume postponed messages.  But the BatchesNeedProcessing method, which factors in the number of postponed messages, is accidentally ignoring the _decliningPermanently flag that indicates completion was requested.  As a result, with just the right sequence of operations, the BatchBlock can get stuck in a state where it sees postponed messages and queues a task to process them, but that task then sees that it's declining permanently and so doesn't touch any of the postponed messages, and then upon checking to see if it can complete, sees there are postponed messages, and loops again, resulting in a potentially infinite asynchronous loop.  The fix is just to check _decliningPermanently in BatchesNeedProcessing when considering postponed messages.

…8537)

n .NET it is not considered a breaking change to move a method from a derived type to its base type. This is reflected by the behavior of memberref processing.

The previous implementation of this in crossgen2 did not correctly handle the substitutions required when processing this form of memberref in the case where the base type is a generic type not instantiated over the same set of generic parameters as the derived type.

This change fixes that, and adds a unit test to that effect.

Fixes #38648

* Moving SIMDIntrinsicInit to use SimdAsHWIntrinsic

* Optimize the simple case of Create(0) and Create(-1) to get_Zero and get_AllBitsSet

* Adding a new gtNewSimdCreateBroadcastNode method

* Updating SIMDIntrinsicGetOne to use SimdAsHWIntrinsic

* Fixing build errors

* Ensure all forms of ToScalar are intrinsic on x86

* Moving SIMDIntrinsicDot to use SimdAsHWIntrinsic

* Removing SIMDIntrinsicDot, SIMDIntrinsicAdd, SIMDIntrinsicMul, and SIMDIntrinsicDiv

* Removing SIMDIntrinsicGetCount, SIMDIntrinsicGetOne, SIMDIntrinsicGetAllOnes, and SIMDIntrinsicGetZero

* Default TYP_SIMD12 constants to be 16 bytes

* Get the simdType from the size for LowerHWIntrinsicDot

* Applying formatting patch

* Use AddPairwise for floating-point dot product

* Applying formatting patch

* Correctly handle decomposed long constants on x86

* Check JitConfig.EnableHWIntrinsic when in impSIMDIntrinsic or impSimdAsHWIntrinsic

* Ensure AdvSimd.Arm64.Multiply is used for TYP_DOUBLE

* Applying formatting patch

* Updating LowerHWIntrinsicCreate to handle TYP_SIMD8 retyped as TYP_DOUBLE and fixing VectorT128_get_One

* Ensure the CreateBroadcast SimdAsHWIntrinsic nodes have the correct gtType

* Applying formatting patch

* Apply suggestions from code review

Co-authored-by: Carol Eidt <carol.eidt@microsoft.com>

* Adding some additional clarifying comments

* Breaking NI_Vector256_ToScalar importation logic into its own checks

* Applying formatting patch

Co-authored-by: Carol Eidt <carol.eidt@microsoft.com>

…ndows (#38372)

* Honor user setting overrides for current culture when using ICU on Windows

* Fix mono build

* PR Feedback, fix builds

* PR Feedback and fix build errors

* Remove using statement

* Fix Invariant tests

* Fix get time formats and PR feedback

* Revert test changes that are not needed

* PR Feedback and cleanup

* Move invariant check for UserDefaultLocaleName to helper method

* Create CLR interpreter Azure DevOps Pipeline

This builds the runtime using:
```
-cmakeargs "-DFEATURE_INTERPRETER=1"
```
and runs Pri-0 tests using the interpreter.

* Replace C++ `assert` with VM-standard `_ASSERTE` in interpreter

It's not supported on WebAssembly so throw PlatformNotSupportedException.

…(#38710)

* Replace linker descriptor for AssemblyBuilder with DynamicDependency

for better linking when AssemblyBuilder is not instantiated.

Contributes to #38692

* Review feedback

* Make DependencyInjection more linker trimmable

Allow the unused ServiceProviderEngine strategy types to be trimmed by the ILLinker.

This allows for System.Linq.Expressions to be completely removed in a default Blazor application. It also removes one of two usages of System.Reflection.Emit.

Fix #38678

* Ask about prior art in API review template

As an example, dotnet/runtime#35088 described an analogous pattern in the Go ecosystem. While we have distinct patterns and rules for .NET API, if there's analogous prior art it may be interesting to compare approaches.

* Update .github/ISSUE_TEMPLATE/02_api_proposal.md

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* generalize clean env check

* Remove in-test timeouts
* timeouts will show up as test failures and trigger dump collection
* Add notification of and diagnostics on early subprocess exit

* move pathologic test to outer loop

* Turn back on other reverse tests

* Respond to PR feedback

The property only checked for the `MONO_ENV_OPTIONS=--interpreter` env var which isn't set on WebAssembly.

This needed an arcade fix to correct an inverted condition in the ActiveIssue discoverer: dotnet/arcade#5744

…38740)

* x86 P/Invokes marked with UnmanagedCallersOnly require marshalling
Fix generated IL for test.

* Always throw NotSupportedException for UnmanagedCallersOnly usage on
  P/Invokes.

…e (#38778)

* Remove redundant initializations in SPC

* Update comment

…8757)

* Replace XML descriptors for SRE with DynamicDependency attributes

Fixes #38692

* Remove duplicate using

…(#38469)

Identify if an assembly has debug information and only download it to debug proxy if it has, this will speed up a lot the debugger initialisation.

Co-authored-by: thaystg <thaystg@users.noreply.github.com>

We'll need a feature switch to turn off support for the parts that read text strings out of resources to make this fully safe.

When fetching a certificate with AIA, we should ignore responses that
are zero bytes in length. A zero-byte value passed to X509Certificate2
will create a default certificate with a null PAL. This was being
passed in to the OpenSSL chain builder, and would pass in a null handle
for the certificate.

ErrrorMessage -> ErrorMessage

Update UWP ownership

Use ExecutionContext.Restore rather than EC.Run callback

Only running inline needs to do extra work and error handling for post run restore

As per discussion with @jeffschwMSFT @marcpopMSFT such issues should be in https://github.com/dotnet/sdk. All active issues already moved, label deleted.

* adrp+add emit displaying

* Add method names in disasm

* jit formatting

* update method signature for arm

* Rename GC to GS to refer Global security

* unique enum MethodHandleType

* Add code-path for field access

* fix build break

* Use gtFlags to track the target handle type

* Rename methodHandle to targetHandle

* revert the change for static field access

* Handle a case where we were getting TOKEN_HANDLE

* fix build break

* some more renaming to relevant name

* fix typo

* fix the linux build break

* Add support for multiple non-string TKey on dictionaries

* Fix build errors

* Fix performance regression

* Add Read/WriteWithQuotes to the remaining supported types

* Add support for a few more missing types

* Add policy support for Enum keys

* Address performance regression.

* Fix test error on netstandard

* 1. Add support for escaped characters on Read and avoid escaping on Write
2. Address some feedback

* Remove TryGet*Core methods to mitigate perf regression

* Remove duplicated escaping tests

* Cache TKey and TValue converters

* Remove duplicated code used to read the dictionary key

* Bring back TryGet*Core

* Fix test errors with floating point types

* Address nits and feedback from steveharter

….Tests.WebSocketTests with an active issue (#38808)

…8761)

* Move rarely used lookup table out of HeaderDescriptor static ctor

* Move QPackStaticTable to its own file

…cs (#38725)

* MultiplyDoublingByScalarSaturateHigh

* MultiplyDoublingBySelectedScalarSaturateHigh

* MultiplyDoublingSaturateHigh

* MultiplyDoublingSaturateHighScalar

* MultiplyDoublingScalarBySelectedScalarSaturateHigh

* MultiplyDoublingWideningAndAddSaturateScalar

* MultiplyDoublingWideningAndSubtractSaturateScalar

* MultiplyDoublingWideningLowerAndAddSaturate

* MultiplyDoublingWideningLowerAndSubtractSaturate

* MultiplyDoublingWideningLowerByScalarAndAddSaturate

* MultiplyDoublingWideningLowerByScalarAndSubtractSaturate

* MultiplyDoublingWideningLowerBySelectedScalarAndAddSaturate

* MultiplyDoublingWideningLowerBySelectedScalarAndSubtractSaturate

* MultiplyDoublingWideningSaturateLower

* MultiplyDoublingWideningSaturateLowerByScalar

* MultiplyDoublingWideningSaturateLowerBySelectedScalar

* MultiplyDoublingWideningSaturateScalar

* MultiplyDoublingWideningSaturateScalarBySelectedScalar

* MultiplyDoublingWideningSaturateUpper

* MultiplyDoublingWideningSaturateUpperByScalar

* MultiplyDoublingWideningSaturateUpperBySelectedScalar

* MultiplyDoublingWideningScalarBySelectedScalarAndAddSaturate

* MultiplyDoublingWideningScalarBySelectedScalarAndSubtractSaturate

* MultiplyDoublingWideningUpperAndAddSaturate

* MultiplyDoublingWideningUpperAndSubtractSaturate

* MultiplyDoublingWideningUpperByScalarAndAddSaturate

* MultiplyDoublingWideningUpperByScalarAndSubtractSaturate

* MultiplyDoublingWideningUpperBySelectedScalarAndAddSaturate

* MultiplyDoublingWideningUpperBySelectedScalarAndSubtractSaturate

* MultiplyRoundedDoublingByScalarSaturateHigh

* MultiplyRoundedDoublingBySelectedScalarSaturateHigh

* MultiplyRoundedDoublingSaturateHigh

* MultiplyRoundedDoublingSaturateHighScalar

* MultiplyRoundedDoublingScalarBySelectedScalarSaturateHigh

The additional testhost binplacing is dead code as the native assets
are already binplaced by default into the testhost.

Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com>

make dist fails as mono/eventpipe/Makefile never makes it into the tarball.

Co-authored-by: nealef <nealef@users.noreply.github.com>

…class with an active issue (#38854)

Issue: dotnet/runtime#36199

Issue: dotnet/runtime#38799

Issue: dotnet/runtime#36681

- Unused QCall
- Unused arguments

* Add linker annotations for System.Text.Json

* Review feedback - don't use property accessors in tests and use normal await pattern

* Add annotations to ref & fix immutable collections

* Address review feedback

* Clean up linker tests

* Fix ref file #if directives

* Clean up

* Re-add Hastable.cs

* Remove serialization code from Deserialize overload tests

* Verify collection deserialization is correct

… tests (#38721)

Adjust AppContext.BaseDirectory to return "/" for wasm because GetEntryAssembly().Location returns an empty string.

This change also enables most of the Microsoft.Extensions.* tests with the exception of DependencyModel and Hosting.

Co-authored-by: radical <radical@users.noreply.github.com>

Add zoneinfo data for System.Runtime.TimeZoneInfoTests
* Include dotnet.timezones.blat in runtime pack
* Adding enable-zoneinfo to runscriptcommand in tests.mobile.targets
* add mono_wasm_load_data to library-mono.js

Co-authored-by: Larry Ewing <lewing@microsoft.com>

…sageHandler (#38733)

All of the tests start a socket-based loopback server which doesn't work on WebAssembly.
We can do the tests using a custom HttpMessageHandler instead of the loopback server as well.

* Add examples of System.Private.CoreLib iterative workflow

* Update build.sh

* PR Feedback

* Disable retyping by default.

* Keep block init/copy as baseline.

Total bytes of diff: -21971 (-0.07% of base)
3075 total methods with Code Size differences (1589 improved, 1486 regressed), 184523 unchanged.

Note: it improves code with retyping as well:
808 total methods with Code Size differences (808 improved, 0 regressed), 186790 unchanged.
Found 55 files with textual diffs.
Crossgen CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for  default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: -22923 (-0.07% of base)

* Don't mark LCL_VAR that is used in RETURN(IND(ADDR(LCL_VAR)) as address taken when possible.

Protect against a promoted struct with a hole like struct<8> {hole 4; int a;};

* Replace 1-field structs with the field for returns.

* Add SSA support.

* Review response.

* isOpaqueSIMDLclVar fix

* Add tests for structs with independently promoted SIMD fields.

* Old retyping fix.

* Don't try to replace SIMD fields.

- UnboxingMethodDesc is a type that is not intended to escape JIT
interface
- This fix is a combination of 2 changes.
  - First, a change for creation of ldtoken to a generic valuetype method
  - Second, moving a bool to indicate whether or not a method is an
  unboxing stub into the MethodWithToken data structure instead of
  passing it as a side parameter everywhere
- Also, a test case for various generic ldtoken cases is added to
crossgen2smoke
- And, minor fix to make single method compilation of a generic method
function correctly. (There was a typo)

`Instr` objects come from a static pool and should not be deleted
with `delete`. Instead, they are marked no longer used by setting
their `opcode` field to -1.

Fixes #12433

Issue: dotnet/runtime#38847

Issue: dotnet/runtime#38887

Issue: dotnet/runtime#38889

* fix failing tests

* fix casing

* feedback from review

* style update

* retire EndEntityIsServer

* logging

* the fix

* revert lclvars.cpp changes

* Revert "revert lclvars.cpp changes"

This reverts commit d39af7084687e8fe5e6d4f71674ec84d36a88340.

* wip

* revert lclvars.cpp changes

* deleted inst_RV_ST()

* removing logging, added some asserts

* jit-formatting

* add back case of INS_add and some more asserts

* reset lclvars.cpp

* delete comments and cleanup code

* revert changes inside common.il

* Revert "Disable failing Windows arm32 tests (#38844)"

This reverts commit 311fd81.

* review comments

* added standard function header

The finalization queue can be long or constantly growing when the finalization thread is not able to
keep up with finalizable object allocation rate. This can lead to shutdown being blocked for a long
time or indefinitely.

The fix is stop the finalization loop once we enter shutdown instead of trying to empty the finalization
queue.

Fixes dotnet#314

* Reenable GitHub_26491.

Closes #13355

* Reenable crossgen2 tests failing with old retyping/

They were fixed both with and without retyping.
Closes #37883.

* Reenable HVA merge cases.

Closes #37341, closes #37880.

* Reenable GitHub_35821.

Closes #36206, closes #36418.

The issue was fixed by #37499.

* Delete extra lines that are no longer needed.

#37506 was fixed in #38241.

* delete a throwing init.

…058)

* Mechanical move of tests from src/coreclr/tests/src to src/tests

* Minimum changes to make CoreCLR tests build in the new location

(*) Path changes in the test build scripts;
(*) Modify runtime.yml filtering based on Nathan's and Santi's feedback;
(*) Fix runtime pipeline filtering clauses per Santi's PR feedback;
(*) Fix path to Coreclr.TestWrapper.csproj;
(*) Pass unprocessed build args to test wrapper creation;
(*) Fix missing $(TestRoot) on groups in Pri0 test build mode.

Thanks

Tomas

Fixes dotnet/runtime#38559

* [interp] Remove usage of some gotos

Their usage resulted in worse code on wasm.

* [interp] Rename method

Seems like something is failing in eglib-remap test