Enable libraries testing #900

MichalStrehovsky · 2021-04-01T10:19:57Z

No description provided.

MichalStrehovsky · 2021-04-06T18:11:29Z

So the System.Runtime tests are hitting an INT 3 with this stack:

>	[Inline Frame] System.Runtime.Tests.exe!WKS::exclusive_sync::check() Line 1124	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::background_mark_phase() Line 30681	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::gc1() Line 18893	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::bgc_thread_function() Line 31740	C++
 	System.Runtime.Tests.exe!GCToEEInterface::CreateThread::__l2::<lambda>(void * argument) Line 1383	C++

The FileSystem tests are not crashing for me, but they also just hang and don't finish.

I've only been testing unoptimized builds locally in the past.

So for now, removing these tests.

MichalStrehovsky · 2021-04-08T09:17:02Z

Okay, this still needs to wait for dotnet/runtime#50898 and dotnet/runtime#50280 at minimum and it still managed to crash despite the turned off optimizations.

On Unix we have some ICU or whatever failures.

And I need to block a couple more tests.

This will never end.

MichalStrehovsky · 2021-04-08T14:24:10Z

So I at least spent some time looking at the hang. We have a bunch of threads waiting for background GC, waiting for suspension, waiting for the GC to complete.

The only two threads that are doing something are the thread trying to do suspension:

>	System.Runtime.Tests.exe!ThreadStore::SuspendAllThreads(bool waitForGCEvent) Line 240	C++
 	System.Runtime.Tests.exe!GCToEEInterface::SuspendEE(SUSPEND_REASON reason) Line 807	C++
 	System.Runtime.Tests.exe!WKS::GCHeap::GarbageCollectGeneration(unsigned int gen, gc_reason reason) Line 42146	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::trigger_gc_for_alloc(int gen_number, gc_reason gr, WKS::GCDebugSpinLock * msl, bool loh_p, WKS::msl_take_state take_state) Line 15740	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::try_allocate_more_space(alloc_context * acontext, unsigned __int64 size, unsigned int flags, int gen_number) Line 15858	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::allocate_more_space(alloc_context * acontext, unsigned __int64 size, unsigned int flags, int alloc_generation_number) Line 16354	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::allocate(unsigned __int64 jsize, alloc_context * acontext, unsigned int flags) Line 16385	C++
 	System.Runtime.Tests.exe!WKS::GCHeap::Alloc(gc_alloc_context * context, unsigned __int64 size, unsigned int flags) Line 41158	C++

But that one cannot make progress because the background GC thread cannot be suspended (we're hitting the codepath in PalGetThreadContext that checks whether the context is accurate and it isn't. But even if we were to succeed there, the background GC thread stack is not walkable so it doesn't help.

The background GC thread is stuck in


>	System.Runtime.Tests.exe!WKS::exclusive_sync::bgc_mark_set(unsigned char * obj) Line 1145	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::revisit_written_page(unsigned char * page, unsigned char * end, int concurrent_p, unsigned char * & last_page, unsigned char * & last_object, int large_objects_p, unsigned __int64 & num_marked_objects) Line 31044	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::revisit_written_pages(int concurrent_p, int reset_only_p) Line 31290	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::background_mark_phase() Line 30597	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::gc1() Line 18891	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::bgc_thread_function() Line 31740	C++
 	System.Runtime.Tests.exe!WKS::gc_heap::bgc_thread_stub(void * arg) Line 29752	C++
 	System.Runtime.Tests.exe!GCToEEInterface::CreateThread::__l2::<lambda>(void * argument) Line 1382	C++

We just keep going to the retry loop because nobody is touching alloc_objects and removing the thing we're checking for because all the other threads are waiting.

I thought that maybe this is caused by not having FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP because I saw code around this that checks for that (I assume nobody tests a GC without this defined over in the CoreCLR repo), but even with that and FEATURE_MANUALLY_MANAGED_CARD_BUNDLES, I don't see improvements.

MichalStrehovsky · 2021-04-13T08:44:31Z

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

@@ -246,7 +246,7 @@ private static Version GetICUVersion()
            int version = 0;
            try
            {
-                Type interopGlobalization = Type.GetType("Interop+Globalization");
+                Type interopGlobalization = Type.GetType("Interop+Globalization, System.Private.CoreLib");


The Interop type exist both in the current assembly and in CoreLib. Apparently we're supposed to try in both. The reflection stack is not structured to fix this in straighforward way. I just really don't care.

jkotas · 2021-04-18T14:01:21Z

src/libraries/System.Runtime/tests/System/GCTests.cs

@@ -917,6 +918,7 @@ long CallGetTotalAllocatedBytes(long previous)
            }
        }

+        [ActiveIssue("https://github.com/dotnet/runtimelab/issues/939" /* NativeAot */)]


This should be fixed now

jkotas · 2021-04-20T14:01:57Z

src/libraries/System.Runtime/tests/System/Reflection/ModuleTests.cs

@@ -81,6 +81,9 @@ public void CustomAttributes()
        [Fact]
        public void FullyQualifiedName()
        {
+#if SINGLE_FILE_TEST_RUNNER


It does not sound right for the test to contain ifdefs like this. It should be a dynamic check instead.

This is already merged with dotnet/runtime#50996 - I cherry picked it because I'm tired of working in two repos.

We don't have a way to build a dynamic check that wouldn't just result in testing a tautology ("on a runtime that returns <Unknown> for FullName, check that FullName returns <Unknown>").

jkotas · 2021-04-20T14:03:20Z

eng/pipelines/runtimelab.yml

@@ -106,7 +106,7 @@ stages:
        isOfficialBuild: ${{ variables.isOfficialBuild }}
        timeoutInMinutes: 90
        testGroup: innerloop
-        buildArgs: -s nativeaot.objwriter+nativeaot+libs+nativeaot.packages -c release
+        buildArgs: -s nativeaot+libs+nativeaot.packages -c release


These shortcuts should be reverted now that the PR is passing.

The PR is passing, but it shouldn't. It has failing tests.

jkotas · 2021-04-21T16:38:19Z

eng/testing/tests.singlefile.targets

+    <!-- xunit calls MakeGenericType to check if something is IEquatable -->
+    <IlcArg Include="--feature:System.Reflection.IsTypeConstructionEagerlyValidated=false" />
+
+    <!-- Disable background GC because we have issues with it - https://github.com/dotnet/runtimelab/issues/940 -->


This should not be needed anymore

This reverts commit ca46750.

MichalStrehovsky · 2021-04-29T08:24:31Z

OK, this is ready for review now!

jkotas

Thank you!

MichalStrehovsky added the area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation label Apr 1, 2021

MichalStrehovsky force-pushed the fxtests branch 3 times, most recently from 0f5a03b to f064433 Compare April 13, 2021 08:41

MichalStrehovsky commented Apr 13, 2021

View reviewed changes

jkotas reviewed Apr 18, 2021

View reviewed changes

jkotas reviewed Apr 20, 2021

View reviewed changes

jkotas reviewed Apr 21, 2021

View reviewed changes

MichalStrehovsky and others added 18 commits April 28, 2021 15:34

Enable libraries testing

4c2fb74

Update runtimelab-post-build-steps.yml

ccf4575

Update runtimelab-post-build-steps.yml

ffe5c4d

asdf

4b918d2

More tests

d01f03f

asdf

5ac8369

Force unoptimized

75bae17

Update tests.proj

f84bcf7

Exclusions

7d0d323

Suppress

382c933

Universal Build Accelerator(tm)

0a72b8f

Analyze nested types

b8bdf7c

feljkndfaknjlnkfanklasdf

e774270

aaa

92def4b

abc

7e06e98

mac

e678099

Revert "Analyze nested types"

4446ca5

This reverts commit ca46750.

Update Microsoft.NETCore.Native.targets

8c735dc

MichalStrehovsky added 6 commits April 28, 2021 15:36

one more

7925d06

Update GCTests.cs

63ca328

reflection cache

f19c59f

wtf

92c6479

try this?

11f139f

deletes

09dbd42

MichalStrehovsky force-pushed the fxtests branch from 4683c67 to 09dbd42 Compare April 28, 2021 13:38

maybe this is it?

fe05503

jkotas approved these changes Apr 29, 2021

View reviewed changes

MichalStrehovsky merged commit a957342 into dotnet:feature/NativeAOT Apr 29, 2021

MichalStrehovsky deleted the fxtests branch April 29, 2021 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable libraries testing #900

Enable libraries testing #900

MichalStrehovsky commented Apr 1, 2021

MichalStrehovsky commented Apr 6, 2021

MichalStrehovsky commented Apr 8, 2021

MichalStrehovsky commented Apr 8, 2021

MichalStrehovsky Apr 13, 2021

jkotas Apr 18, 2021

jkotas Apr 20, 2021

MichalStrehovsky Apr 20, 2021

jkotas Apr 20, 2021

MichalStrehovsky Apr 20, 2021

jkotas Apr 21, 2021

MichalStrehovsky commented Apr 29, 2021

jkotas left a comment

Enable libraries testing #900

Enable libraries testing #900

Conversation

MichalStrehovsky commented Apr 1, 2021

MichalStrehovsky commented Apr 6, 2021

MichalStrehovsky commented Apr 8, 2021

MichalStrehovsky commented Apr 8, 2021

MichalStrehovsky Apr 13, 2021

Choose a reason for hiding this comment

jkotas Apr 18, 2021

Choose a reason for hiding this comment

jkotas Apr 20, 2021

Choose a reason for hiding this comment

MichalStrehovsky Apr 20, 2021

Choose a reason for hiding this comment

jkotas Apr 20, 2021

Choose a reason for hiding this comment

MichalStrehovsky Apr 20, 2021

Choose a reason for hiding this comment

jkotas Apr 21, 2021

Choose a reason for hiding this comment

MichalStrehovsky commented Apr 29, 2021

jkotas left a comment

Choose a reason for hiding this comment