-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Forms TaskDialog API sample #3702
Add Windows Forms TaskDialog API sample #3702
Conversation
e9a7f75
to
0d5b413
Compare
0d5b413
to
e0dff7e
Compare
Thanks for adding this here! This sample should be split into two, a csharp one and a vb one. Basically, add a readme in the root directory for each sample, it should contain a metadata header so that the sample shows up in the samples browser. Here is an example of the header: https://raw.githubusercontent.com/dotnet/samples/master/mef/simple-calculator/vb/readme.md Which looks like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested based on the previous comment.
Updated, please have a look |
Thanks! Which preview of .NET 5 is required? |
.NET 5.0 Preview 4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final changes and we're good-to-go. Thanks a bunch for helping out!
0634fe3
to
c2fbf6d
Compare
done |
c2fbf6d
to
c38457d
Compare
I'm going to hold off on merging this. I have a PR that enables our CI testing and I need to update it for .NET 5, so this PR is a great test case. Is that OK? Let me know. Thanks! |
No worries. No rush on my part. Thank you |
Summary
Add a sample for Windows Forms TaskDialog API, that was added in .NET 5.0 in dotnet/winforms#1133.
Credits: this sample was authored by @kpreisser in https://github.com/kpreisser/TaskDialogDemo, the author of
Task Dialog
for Windows Forms.