Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Forms TaskDialog API sample #3702

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Jul 6, 2020

Summary

Add a sample for Windows Forms TaskDialog API, that was added in .NET 5.0 in dotnet/winforms#1133.

Credits: this sample was authored by @kpreisser in https://github.com/kpreisser/TaskDialogDemo, the author of Task Dialog for Windows Forms.

@RussKie RussKie requested a review from adegeo as a code owner July 6, 2020 08:02
@RussKie
Copy link
Member Author

RussKie commented Jul 6, 2020

/cc: @OliaG @merriemcgaw @Olina-Zhang

@RussKie RussKie force-pushed the Add_WindowsForms_TaskDialog_demo branch from e9a7f75 to 0d5b413 Compare July 6, 2020 08:04
@RussKie RussKie force-pushed the Add_WindowsForms_TaskDialog_demo branch from 0d5b413 to e0dff7e Compare July 6, 2020 08:06
@adegeo
Copy link
Contributor

adegeo commented Jul 6, 2020

Thanks for adding this here! This sample should be split into two, a csharp one and a vb one. Basically, add a readme in the root directory for each sample, it should contain a metadata header so that the sample shows up in the samples browser. Here is an example of the header: https://raw.githubusercontent.com/dotnet/samples/master/mef/simple-calculator/vb/readme.md

Which looks like this:

---
languages:
- vb
products:
- dotnet-core
- windows
page_type: sample
name: "MEF Sample: Simple Calculator (Visual Basic)"
urlFragment: "simple-calculator-vb"
description: "A .NET Core console application that contains the example method from Simple Calculator MEF Application in Visual Basic."
---

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested based on the previous comment.

@adegeo adegeo added the blocked Indicates PRs that are blocked for some reason label Jul 6, 2020
@RussKie
Copy link
Member Author

RussKie commented Jul 7, 2020

Updated, please have a look

@adegeo
Copy link
Contributor

adegeo commented Jul 7, 2020

Thanks! Which preview of .NET 5 is required?

@RussKie
Copy link
Member Author

RussKie commented Jul 7, 2020 via email

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes and we're good-to-go. Thanks a bunch for helping out!

windowsforms/TaskDialogDemo/cs/README.md Outdated Show resolved Hide resolved
windowsforms/TaskDialogDemo/vb/TaskDialogDemo.sln Outdated Show resolved Hide resolved
windowsforms/TaskDialogDemo/vb/README.md Outdated Show resolved Hide resolved
@RussKie RussKie force-pushed the Add_WindowsForms_TaskDialog_demo branch from 0634fe3 to c2fbf6d Compare July 7, 2020 01:27
@RussKie
Copy link
Member Author

RussKie commented Jul 7, 2020

done

@RussKie RussKie force-pushed the Add_WindowsForms_TaskDialog_demo branch from c2fbf6d to c38457d Compare July 7, 2020 01:30
@adegeo
Copy link
Contributor

adegeo commented Jul 7, 2020

I'm going to hold off on merging this. I have a PR that enables our CI testing and I need to update it for .NET 5, so this PR is a great test case. Is that OK? Let me know. Thanks!

@RussKie
Copy link
Member Author

RussKie commented Jul 7, 2020

No worries. No rush on my part. Thank you

@adegeo adegeo closed this Jul 7, 2020
@adegeo adegeo reopened this Jul 7, 2020
@adegeo adegeo closed this Jul 7, 2020
@adegeo adegeo reopened this Jul 7, 2020
@adegeo adegeo merged commit d5edbc9 into dotnet:master Jul 7, 2020
@RussKie RussKie deleted the Add_WindowsForms_TaskDialog_demo branch July 8, 2020 05:32
@adegeo adegeo removed the blocked Indicates PRs that are blocked for some reason label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants