Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile #741

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Fix compile #741

merged 2 commits into from
Mar 25, 2019

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Mar 23, 2019

Summary

The bracket can not be added after the class name.

Assembly.GetCallingAssembly Method (System.Reflection)

In [corefx/coding-style.md at master · dotnet/corefx](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md ) NO.1, we use Allman style braces, where each brace begins on a new line. A single line statement block can go without braces but the block must be properly indented on its own line and must not be nested in other statement blocks that use braces (See issue 381 for examples). One exception is that a using statement is permitted to be nested within another using statement by starting on the following line at the same indentation level, even if the nested using contains a controlled block.
The bracket can not be added after the class name.
@lindexi
Copy link
Contributor Author

lindexi commented Mar 23, 2019

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and fixing it @lindexi

I've reviewed the changes, and I'll :shipit: now.

@BillWagner BillWagner merged commit 64708a4 into dotnet:master Mar 25, 2019
@lindexi lindexi deleted the t/lindexi/getcallingassembly branch April 5, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants