Removing DocumentationFile path from migration and one test asset.

dotnet · Nov 4, 2016 · d68341b · d68341b
1 parent cb7c936
commit d68341b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/TestAssets/TestProjects/TestLibraryWithConfiguration/TestLibraryWithConfiguration.csproj b/TestAssets/TestProjects/TestLibraryWithConfiguration/TestLibraryWithConfiguration.csproj
@@ -5,7 +5,6 @@
     <TargetFramework>netstandard1.5</TargetFramework>
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <DocumentationFile>$(OutputPath)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="**\*.cs" Exclude="bin\**;obj\**;**\*.xproj;packages\**" />

diff --git a/src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs b/src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigrateBuildOptionsRule.cs
@@ -96,13 +96,7 @@ private AddPropertyTransform<CommonCompilerOptions>[] KeyFileTransforms
         private AddPropertyTransform<CommonCompilerOptions> XmlDocTransform =>
             new AddPropertyTransform<CommonCompilerOptions>("GenerateDocumentationFile",
                 compilerOptions => compilerOptions.GenerateXmlDocumentation.ToString().ToLower(),
-                compilerOptions => compilerOptions.GenerateXmlDocumentation != null && compilerOptions.GenerateXmlDocumentation.Value);
-
-        // TODO: https://github.com/dotnet/sdk/issues/67
-        private AddPropertyTransform<CommonCompilerOptions> XmlDocTransformFilePath =>
-            new AddPropertyTransform<CommonCompilerOptions>("DocumentationFile",
-                @"$(OutputPath)\$(TargetFramework)\$(AssemblyName).xml",
-                compilerOptions => compilerOptions.GenerateXmlDocumentation != null && compilerOptions.GenerateXmlDocumentation.Value);
+                compilerOptions => compilerOptions.GenerateXmlDocumentation != null && compilerOptions.GenerateXmlDocumentation.Value);    
 
         private AddPropertyTransform<CommonCompilerOptions> AssemblyNameTransform =>
             new AddPropertyTransform<CommonCompilerOptions>("AssemblyName",
@@ -177,7 +171,6 @@ private void ConstructTransformLists()
                 PublicSignTransform,
                 DebugTypeTransform,
                 XmlDocTransform,
-                XmlDocTransformFilePath,
                 PreserveCompilationContextTransform,
                 AssemblyNameTransform
             };