-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict resolution with packages.config-based projects results in yellow warnings in Solution explorer #1499
Comments
A workaround for this is to add the following to your project file:
|
Is an alternative solution to remove the system.net.http reference from the console app as it's the lib that requires system.net.http? |
Sure, for everything that shows up with the yellow bang you can delete it from the CSProj since it will be provided by the targets. That will also work. That would require you to do so after NuGet adds them there (if they are coming from a package in packages.config based project for example). |
It's similar but the fix in #1454 may not be big enough. I think we need to consider any case where we might remove items from Reference. For example: conflict resolution. |
I confirm these lines seem to solve the issue:
|
or
Even if the reference came from a nuget package resolved through packagereference, or a targets that added the file.
|
To reproduce:
Expect: Builds successfully with no warnings in IDE or solution explorer.
![image](https://user-images.githubusercontent.com/8918108/29379290-d47d1610-8276-11e7-8901-0aa68593aebf.png)
Actual: Builds successfully, but warnings appear in IDE and solution explorer shows yellow warning icon next to references.
This is essentially the same as #1244 but a different way to get there. In this case it wasn't simple name conflict resolution but the task.
Because conflict resolution removes the items that were directly authored in the csproj by nuget the IDE emits a warning because it cannot reconcile that the winning items should actually be used.
I think we need to come up with a strategy that works for both places and makes the IDE happy with the consolidated references.
/cc @dsplaisted
The text was updated successfully, but these errors were encountered: