Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConflictResolver.ResolveConflict is ~3.3% of all allocations in solution-wide design-time build #1604

Closed
davkean opened this issue Sep 26, 2017 · 3 comments
Assignees
Milestone

Comments

@davkean
Copy link
Member

davkean commented Sep 26, 2017

image

@ericstj
Copy link
Member

ericstj commented Oct 16, 2017

Bigger question here is why does this reference graph result in conflicts? We should do work to ensure packages are moved forward to provide dependency groups that don't pull in old packages (and thus excessive downloads and conflicts).

I would expect a "happy path" project to never call this method.

Barring that, some work could be done to avoid excessive string allocations here. I would imagine that would mean using more LogMessage overloads with formatting parameters that let the logger decide if it needs to format the string (allocating) or not.

@nguerrera
Copy link
Contributor

This might be fixed with @eerhardt's changes.

@livarcocc livarcocc added this to the 2.1.3xx milestone Feb 9, 2018
@nguerrera
Copy link
Contributor

Fixed by #1805

JL03-Yue pushed a commit that referenced this issue Mar 19, 2024
Add NuGet Package Source Mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants