Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report "preview" more classy #34526

Open
richlander opened this issue Aug 8, 2023 · 2 comments
Open

Report "preview" more classy #34526

richlander opened this issue Aug 8, 2023 · 2 comments
Labels
Area-NetSDK untriaged Request triage from a team member
Milestone

Comments

@richlander
Copy link
Member

It should be no surprise that I install a LOT of previews.

The following is really poor UX.

  • Warning is ever-present. The only "fixer" for this is to uninstall the preview. That seems odd.
  • The first line presented is a version, but isn't the version at issue and doesn't state that it is a preview.
  • No other versions (beyond file paths) are presented

More generally, why are we showing the MSBuild "logo" at all? We're not doing that for NuGet. We should go "no logo" for all the components we use and print the .NET version and feel free to put "preview" in marquee. At that point, we can hopefully get rid of this warning.

$ dotnet build
MSBuild version 17.7.0+5785ed5c2 for .NET
  Determining projects to restore...
  Restored /home/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj (in 595 ms).
/usr/share/dotnet/sdk/8.0.100-preview.6.23330.14/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/home/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/aspnetapp.csproj]
  aspnetapp -> /home/rich/git/dotnet-docker/samples/aspnetapp/aspnetapp/bin/Debug/net8.0/aspnetapp.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:04.36
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Aug 8, 2023
@jaredpar
Copy link
Member

jaredpar commented Aug 8, 2023

The other issue with the preview message is that it displays once for every project being built, not once per build. That can really clutter up your build output when building large projects.

@richlander
Copy link
Member Author

100% true. That part is super annoying.

#10352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

3 participants