Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update dependencies from mono/linker #14925

Merged
merged 11 commits into from
Dec 15, 2020
Merged

[master] Update dependencies from mono/linker #14925

merged 11 commits into from
Dec 15, 2020

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 10, 2020 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 9ac01057-d33d-4509-c9e1-08d846b6e5b9
  • Build: 20201215.1
  • Date Produced: 12/15/2020 9:44 AM
  • Commit: a074fbfd1d0d639893bd61afc7e946a275af9e55
  • Branch: refs/heads/master

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201210.1
0de0b07 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20610.1
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201211.1
8e10462 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.1
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201211.2
e121ecb 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.2
@marek-safar
Copy link
Contributor

@sbomer this PR is blocked because of the XML descriptor breaking change. The failing test is Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink.ILLink_respects_feature_settings_from_host_config. Maybe we should change the warning to be an error.

resource ILLink.Substitutions.xml in HelloWorld, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null : warning IL2101: Embedded XML in assembly 'HelloWorld' contains assembly "fullname" attribute for another assembly 'ClassLibForILLink, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' [C:\h\w\B6C709AD\t\dotnetSdkTests\zfbva2hp.w0h\ILLink_respec---D9B75401\HelloWorld\HelloWorld.csproj]

Then there is second problem which looks like is caused by the automatic removal of default ctors for serializable types.

Fatal error. Internal CLR error. (0x80131506)
   at System.RuntimeTypeHandle.CreateInstanceForAnotherGenericParameter(System.RuntimeType, System.RuntimeType)
   at System.Collections.Generic.ComparerHelpers.CreateDefaultEqualityComparer(System.Type)
   at System.Collections.Generic.EqualityComparer`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..cctor()
   at System.Collections.Generic.EqualityComparer`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].get_Default()
   at System.Collections.Generic.NonRandomizedStringEqualityComparer..cctor()
   at System.Collections.Generic.Dictionary`2[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..ctor(Int32, System.Collections.Generic.IEqualityComparer`1<System.__Canon>)
   at System.AppContext.Setup(Char**, Char**, Int32)

@vitek-karas This shows up in runtime update as well dotnet/runtime#45926 and it looks like we are missing annotations somewhere.

@marek-safar
Copy link
Contributor

Fixed the second problem by reverting the change

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201211.3
f4a6b63 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.3
sbomer added a commit to sbomer/sdk that referenced this pull request Dec 11, 2020
@sbomer
Fix illink test
1fb3d1e 
Avoids modifying other assemblies in embedded XML, in response to
dotnet/linker#1675.

This will unblock dependency flow in dotnet#14925.
sbomer added a commit to sbomer/sdk that referenced this pull request Dec 11, 2020
@sbomer
Fix illink test
fca2254 
Avoids modifying other assemblies in embedded XML, in response to
dotnet/linker#1675.

This will unblock dependency flow in dotnet#14925.
@sbomer sbomer mentioned this pull request Dec 11, 2020
Merged
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201211.4
28eb637 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20611.4
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201214.1
3230664 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.1
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201214.2
253b4ab 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.2
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201214.3
3c2a005 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.3
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201214.4
8739ac2 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.4
sbomer added a commit that referenced this pull request Dec 14, 2020
@sbomer
Fix illink test (#14939)
8bf62d8 
* Fix illink test

Avoids modifying other assemblies in embedded XML, in response to
dotnet/linker#1675.

This will unblock dependency flow in #14925.

* Avoid deconstructing KeyValuePair

Not implemented in .NET Framework
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201214.5
3caf954 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20614.5
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20201215.1
e064f4b 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.0-alpha.1.20608.3 -> To Version 6.0.0-alpha.1.20615.1
@dotnet-maestro dotnet-maestro bot merged commit 629e828 into master Dec 15, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-70b7463d-b779-49b9-a848-870b9f513d5c branch December 15, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marek-safar