Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update support libraries to those that are only lib." #1610

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

dsplaisted
Copy link
Member

Reverts #1582, which broke ASP.NET Core web apps running on .NET Framework.

A description of the issue, thanks to @eerhardt:

Previously we used to reference both the “ref assembly” to compile and the “runtime assembly” to run. Now, we are no longer referencing the “ref assembly” at compile time. We are compiling and running solely against the “runtime assembly”.

This changed the way the .deps.json file is created. For the assembly it is looking for “Microsoft.Win32.Primitives”, the deps.json file changed from:

"Microsoft.Win32.Primitives/4.0.3.0": {
      "type": "referenceassembly",

In the old file to

    "Microsoft.Win32.Primitives/4.0.3.0": {
      "type": "reference",

We have a pretty well-known bug in the 2.0.0 version of the DependencyModel library that was fixed in 2.0.1 - https://github.com/dotnet/core-setup/issues/2981. Basically, the DependencyModel doesn’t resolve “type: reference” libraries correctly.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert? The issue this is fixing is a bigger problem for customers than the regression (a bug in that component) and the regression has a simple workaround. Moreover I discussed with you a small change to this issue that would not cause the regression.

@dsplaisted
Copy link
Member Author

@ericstj We basically have to have a build with a fix by tomorrow morning, so reverting the change is less risky than even applying a simple fix.

The bug in DependencyModel (when combined with the fixes in #1582) completely breaks ASP.NET Core web apps running on .NET Framework.

#1582 does have important fixes in it, so we will try to get those fixes together with a workaround for the DependencyModel issue out as soon as possible, hopefully in 15.4.1.

@ericstj
Copy link
Member

ericstj commented Sep 27, 2017

I am not intending to block this, but I do disaaporove of revert for the reasons mentioned above. At a minimum I'd like to see you explain how you intend to fix this the right way and a timeline for that.

@dsplaisted
Copy link
Member Author

@ericstj Here's the PR which brings back the fixes: #1612

@nguerrera nguerrera deleted the revert-1582-updateNetFxNS2Bits branch October 17, 2017 16:10
JL03-Yue pushed a commit that referenced this pull request Mar 19, 2024
…c50-97ee-3e3a8ab26249

[release/6.x] Update dependencies from dotnet/arcade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants