Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing work for dotnet nuget verify command #16849

Merged
merged 7 commits into from
Apr 17, 2021
Merged

Conversation

kartheekp-ms
Copy link
Contributor

@kartheekp-ms kartheekp-ms commented Apr 12, 2021

Fixes: #13702

Description

I work on NuGet Client team. We added dotnet nuget verify command to dotnet SDK. Added this command to the parser for tab completion. This is my first PR in this repo. If there are better ways to develop parsing logic for the said command, please let me know.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/Cli/dotnet/commands/dotnet-nuget/NuGetCommandParser.cs Outdated Show resolved Hide resolved
@kartheekp-ms kartheekp-ms marked this pull request as ready for review April 12, 2021 16:17
@kartheekp-ms kartheekp-ms requested a review from a team April 12, 2021 16:20
@kartheekp-ms
Copy link
Contributor Author

@dotnet/nuget-team - FYI - I am planning to merge this PR by tomorrow evening unless if there is any feedback that requires a code change.

@kartheekp-ms kartheekp-ms merged commit d53a0e2 into main Apr 17, 2021
@kartheekp-ms kartheekp-ms deleted the kapenaga-nugetverify branch April 17, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet nuget verify command
3 participants