Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert NuGet Build 4.6.0-preview2-4706 into sdk #1807

Closed
wants to merge 2 commits into from

Conversation

nugetlurker
Copy link
Collaborator

Insert NuGet Build 4.6.0-preview2-4706 into sdk master branch

@johnbeisner
Copy link
Contributor

johnbeisner commented Dec 9, 2017

@tannergooding
Did you mention that you had a fix to the package error?

@tannergooding
Copy link
Member

@johnbeisner, the remaining issues I know about should be resolved by #1804

@emgarten
Copy link
Member

Rebasing on the latest master

@emgarten
Copy link
Member

Looks like this is failing with
error NU1608: Detected package version outside of dependency constraint: Microsoft.Build.Tasks.Core 15.1.1012 requires Microsoft.Build.Framework (= 15.1.1012) but version Microsoft.Build.Framework 15.4.8 was resolved. [/Users/dotnet-bot/j/workspace/dotnet_sdk/master/debug_osx10.12_prtest/sdk.sln]

Is there an exact version of Microsoft.Build.Framework that NuGet should reference here? Or should this be NoWarned?

@johnbeisner
Copy link
Contributor

@emgarten
We are going to need to resolve CLI first before addressing the SDK, SDK will take a reference to the CLI build with the new NuGet version.

@johnbeisner
Copy link
Contributor

NuGet team is authoring a fix; reference: dotnet/cli#8200

@nguerrera nguerrera deleted the nuget-insertbuild4706 branch December 19, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants