[release/6.0.1xx] Use the portable rid for --use-current-runtime (backports #21748) #27849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
18 tasks
ayakael
force-pushed
the
backport/pr-21748-to-release/6.0.1xx
branch
from
4f17e5a
to
92ee7d7
Compare
|
@dsplaisted CI is green. This is necessary for source-build as it fixes a bug that our test suite flags. |
dsplaisted
approved these changes
Nov 8, 2022
Updated description with necessary info. |
|
FYI @marcpopMSFT for servicing, I think this would go in January now? |
|
Correct, we are code complete for the December release at this time. |
|
@dsplaisted @ayakael can you send mail to tactics for approval as the branches are now open though only for ~1 day |
|
This is approved for the February release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #21748 to 6.0.1xx
Per @tmds
Customer impact
--use-current-runtimeis broken when building a non-portable SDK, outputting a non-portable RID when we should be outputting the portable RID. Multiple fixes were implemented along the way. This, with dotnet/installer#14816, should finally fix this issue.Testing
Risk
Low, as it has been backported to other 6.0.xxx feature sets.