[main] Update dependencies from dotnet/windowsdesktop #28897

dotnet-maestro · 2022-11-04T12:09:10Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NET.Sdk.WindowsDesktop: from 8.0.0-alpha.1.22551.2 to 8.0.0-alpha.1.22601.6 (parent: Microsoft.WindowsDesktop.App.Ref)

From https://github.com/dotnet/windowsdesktop

Subscription: 43b77b68-0b3c-49dd-3915-08d8e9750bf8
Build: 20221202.2
Date Produced: December 2, 2022 3:01:18 PM UTC
Commit: 8461d6590a4b96d636037868bd5ac7ee2904dd33
Branch: refs/heads/main

Updates:
- Microsoft.WindowsDesktop.App.Ref: from 8.0.0-alpha.1.22552.1 to 8.0.0-alpha.1.22602.2
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-alpha.1.22552.1 to 8.0.0-alpha.1.22602.2
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0: from 8.0.0-alpha.1.22552.1 to 8.0.0-alpha.1.22602.2
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0: from 8.0.0-alpha.1.22552.1 to 8.0.0-alpha.1.22602.2
- Microsoft.NET.Sdk.WindowsDesktop: from 8.0.0-alpha.1.22551.2 to 8.0.0-alpha.1.22601.6

…ld 20221103.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22553.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22552.1 (parent: Microsoft.WindowsDesktop.App.Ref

dotnet-maestro · 2022-11-04T13:04:52Z

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

dotnet-maestro · 2022-11-05T00:17:46Z

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

dotnet-maestro · 2022-11-05T00:27:59Z

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

@dotnet/wpf-developers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/windowsdesktop) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…ld 20221104.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22554.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22553.1 (parent: Microsoft.WindowsDesktop.App.Ref

…ld 20221105.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22555.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22554.1 (parent: Microsoft.WindowsDesktop.App.Ref

…ld 20221106.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22556.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22555.2 (parent: Microsoft.WindowsDesktop.App.Ref

…ld 20221107.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22557.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22556.1 (parent: Microsoft.WindowsDesktop.App.Ref

v-wuzhai · 2022-11-09T06:57:05Z

/azp run

azure-pipelines · 2022-11-09T06:57:15Z

Azure Pipelines successfully started running 1 pipeline(s).

v-wuzhai · 2022-11-09T10:08:42Z

These test failures all look real.

…ld 20221108.1 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22558.1 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22557.1 (parent: Microsoft.WindowsDesktop.App.Ref

dreddy-work · 2022-11-10T01:35:34Z

@marcpopMSFT , Can you help unblock this PR?

RussKie · 2022-11-10T04:47:58Z

Looks like something WPF-related is causing the tests to fail

Process ID: 4320
    Microsoft.NET.Build.Tests.GivenThatWeWantToBuildAWindowsDesktopProject.It_builds_successfully_when_targeting_net_framework [FAIL]
      Expected command to pass but it did not.
      File Name: C:\h\w\C12809C2\p\d\dotnet.exe
      Arguments: msbuild /t:Build C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj /restore
      Exit Code: 1
      StdOut:
      MSBuild version 17.5.0-preview-22555-01+3bcada934 for .NET
        Determining projects to restore...
        Restored C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj (in 209 ms).
      C:\h\w\C12809C2\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(275,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj]
      C:\h\w\C12809C2\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\C12809C2\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net8.0\PresentationBuildTasks.dll. Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj]
      StdErr:
      
      
      Stack Trace:
           at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
           at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
           at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
           at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
           at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
           at FluentAssertions.Execution.AssertionScope.FailWith(String message)
        /_/src/Tests/Microsoft.NET.TestFramework/Assertions/CommandResultAssertions.cs(33,0): at Microsoft.NET.TestFramework.Assertions.CommandResultAssertions.Pass()
        /_/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs(173,0): at Microsoft.NET.Build.Tests.GivenThatWeWantToBuildAWindowsDesktopProject.It_builds_successfully_when_targeting_net_framework()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      Output:
        > C:\h\w\C12809C2\p\d\dotnet.exe new wpf --no-restore --debug:ephemeral-hive
        The template "WPF Application" was created successfully.
        > C:\h\w\C12809C2\p\d\dotnet.exe msbuild /t:Build C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj /restore
        MSBuild version 17.5.0-preview-22555-01+3bcada934 for .NET
          Determining projects to restore...
          Restored C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj (in 209 ms).
        C:\h\w\C12809C2\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(275,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj]
        C:\h\w\C12809C2\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\C12809C2\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net8.0\PresentationBuildTasks.dll. Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\C12809C2\t\dotnetSdkTests\znt5zvxc.4ht\It_builds_suc---1E1E42EA\It_builds_suc---1E1E42EA.csproj]
        Exit Code: 1

/cc: @singhashish-wpf

rchauhan18 · 2022-11-10T12:19:31Z

Error:
The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\B0DC0A37\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net8.0\PresentationBuildTasks.dll. Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

@marcpopMSFT Any pointers on it?

marcpopMSFT · 2022-11-10T17:56:45Z

No idea. My best hunch is you may need the 8.0 SDK to be building the SDK repo so you may be blocked on #28563

nagilson · 2022-11-21T17:09:15Z

That's merged now, rerunning to see if fixed.

nagilson · 2022-11-21T17:09:24Z

/azp run

azure-pipelines · 2022-11-21T17:09:35Z

Azure Pipelines successfully started running 1 pipeline(s).

dreddy-work · 2022-11-21T19:58:21Z

Running C:\h\w\B2610971\p\d\dotnet.exe msbuild /t:Build C:\h\w\B2610971\t\dotnetSdkTests\vordvssr.25p\It_does_not_w---66AEA475\windowsDesktopSdk\windowsDesktopSdk.csproj /restore
Process ID: 6376
Microsoft.NET.Build.Tests.GivenThatWeWantToBuildAWindowsDesktopProject.It_errors_when_missing_windows_target_platform [SKIP]
Failed to determine the version required by this test (16.7.0-preview-20310-07).

dreddy-work · 2022-11-21T19:58:53Z

Any idea on above error @marcpopMSFT / @nagilson ?

dreddy-work · 2022-11-21T20:00:02Z

Should following need to be changed?

sdk/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs

Line 23 in 86117ad

[WindowsOnlyRequiresMSBuildVersionTheory("16.7.0-preview-20310-07")]

dreddy-work · 2022-11-21T20:02:18Z

@sfoslund FYI.

marcpopMSFT · 2022-11-21T20:04:43Z

Sarah is no longer on the team. You can change that version to be 16.7.0 and that should be sufficient or remove it entirely since we don't run on older MSBuild versions anymore.

dreddy-work · 2022-11-21T20:14:28Z

I also see following:

MSBuild version 17.5.0-preview-22567-05+7037436dc for .NET
Determining projects to restore...
All projects are up-to-date for restore.
C:\h\w\B2610971\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(275,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\h\w\B2610971\t\dotnetSdkTests\iwbnuaxz.ysu\It_builds_a_vb_wpf_app\It_builds_a_vb_wpf_app.vbproj]
C:\h\w\B2610971\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\targets\Microsoft.WinFX.targets(211,9): error MSB4062: The "Microsoft.Build.Tasks.Windows.MarkupCompilePass1" task could not be loaded from the assembly C:\h\w\B2610971\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.WindowsDesktop\tools\net8.0\PresentationBuildTasks.dll. Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. Confirm that the declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\B2610971\t\dotnetSdkTests\iwbnuaxz.ysu\It_builds_a_vb_wpf_app\It_builds_a_vb_wpf_app.vbproj]
StdErr:

  Stack Trace:
       at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
       at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
       at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
       at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
       at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
       at FluentAssertions.Execution.AssertionScope.FailWith(String message)
    /_/src/Tests/Microsoft.NET.TestFramework/Assertions/CommandResultAssertions.cs(33,0): at Microsoft.NET.TestFramework.Assertions.CommandResultAssertions.Pass()
    /_/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseVB.cs(196,0): at Microsoft.NET.Build.Tests.GivenThatWeWantToUseVB.It_builds_a_vb_wpf_app()
       at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
       at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

marcpopMSFT · 2022-11-21T21:27:20Z

@dreddy-work by any chance, is the task MarkupCompilePass1 targeting 7.0 still? I was seeing errors like this before when tasks were still targeting 7.0 in the SDK in the other PR.

CC @rainersigwald in case he knows of upgrade issues that affect tasks.

marcpopMSFT · 2022-11-30T22:40:23Z

@kartheekp-ms @nkolev92 We have a test where we were expecting NETSDK1136: The target platform must be set to Windows (usually by including '-windows' in the TargetFramework property) when using Windows Forms or WPF, or referencing projects or packages that do so. and now we're seeing C:\h\w\B7D909EB\t\dotnetSdkTests\hbf5fo2n.ikh\It_errors_whe---88229FEB\MissingTargetPlatform\MissingTargetPlatform.csproj : error NU1012: Platform version is not present for one or more target frameworks, even though they have specified a platform: net8.0-custom

Did something change in the nuget side to fail earlier?

marcpopMSFT · 2022-11-30T22:40:51Z

@rainersigwald after both our changes, I still see some usingtask errors about System.Runtime.

rainersigwald · 2022-11-30T22:48:07Z

I see it, Microsoft.NET.Publish.Tests.PublishWpfApp.It_publishes_and_runs_self_contained_wpf_app. trying to repro locally

rainersigwald · 2022-11-30T23:08:16Z

Same story here:

// S:\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App\8.0.0-alpha.1.22578.1\System.Runtime.dll
// System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a

But . . . I tried this build. I thought!

nkolev92 · 2022-11-30T23:10:44Z

I don't see anything obvious from NuGet side.

NU1012 is raised from within restore.

rainersigwald · 2022-11-30T23:14:08Z

Ok, even in the latest installer zips, that file is still 7.0.0. So I must have been mistaken when I thought the update fixed things. I don't see a way to get this through without an installer build that has an 8.0.0.0 assembly there. Not sure if that's not there because the runtime fix hasn't flowed, or because the runtime fix didn't catch everything.

vlada-shubina · 2022-12-01T08:42:24Z

@GangWang01 could you please check this PR? Looks like new templates were added, and modification to snapshots may be needed.

dreddy-work · 2022-12-01T18:35:43Z

@marcpopMSFT / @rainersigwald / @mmitche , who would be right people to get runtime up to date with installer here?

joeloff · 2022-12-01T18:51:28Z

I just looked at the alpha.1.22601.1 build and it is still 7.0.0

joeloff · 2022-12-01T18:55:04Z

This is the problem: https://github.com/dotnet/runtime/blob/main/eng/Versions.props#L17

@dotnet/runtime-infrastructure the runtime.zips for 8.0 are all versioned as 7.0.0, is someone looking at fixing this?

rainersigwald · 2022-12-01T19:02:27Z

Ah, looks like the change I saw was backed out: dotnet/runtime#77899.

I think that might actually mean that if you update the SDK you build with in windowsdesktop, it'll fix the reference back to 7.0 and then this will work. That sound worth trying @dreddy-work?

rainersigwald · 2022-12-01T19:22:12Z

It'd need to be in WPF where PresentationBuildTasks.dll gets built; I am hitting some trouble trying it locally. Attempting an alternate idea.

ViktorHofer · 2022-12-01T19:23:04Z

https://github.com/orgs/dotnet/teams/runtime-infrastructure the runtime.zips for 8.0 are all versioned as 7.0.0, is someone looking at fixing this?

Yes, we are working on updating from net7.0 to net8.0 (including assembly versions) in dotnet/runtime#78354 but that will take more time. What makes this suddenly blocking a component's dependency flow?

rainersigwald · 2022-12-01T19:25:28Z

What makes this suddenly blocking a component's dependency flow?

The component was built in the window where there was an 8.0.0.0 version, so it can't run on a runtime that now has a 7.0.0.0 version again.

marcpopMSFT · 2022-12-01T21:18:28Z

So do we need dotnet/installer#14991 to get in and then update this PR to use that build or have WindowsDesktop pick up a new runtime?

rainersigwald · 2022-12-01T21:30:47Z

WPF needs a new sdk in their global.json, then that needs to flow to windowsdesktop, then I think it'll Just Work.

rainersigwald · 2022-12-01T21:41:46Z

I confirmed on a local build that dotnet/wpf#7336 produces a PresentationBuildTasks.dll with a reference to System.Runtime, Version=7.0.0.0. I didn't test end to end because that's hard, though.

joeloff · 2022-12-01T21:59:57Z

I confirmed on a local build that dotnet/wpf#7336 produces a PresentationBuildTasks.dll with a reference to System.Runtime, Version=7.0.0.0. I didn't test end to end because that's hard, though.

I agree - this is just a really bad timing issue.

akoeplinger · 2022-12-02T11:32:32Z

The windowsdesktop official build needs a fix to the build image names since the old ones don't exist anymore: dotnet/windowsdesktop#3328

…ld 20221202.2 Microsoft.WindowsDesktop.App.Ref , Microsoft.WindowsDesktop.App.Runtime.win-x64 , VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0 , VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0 From Version 8.0.0-alpha.1.22552.1 -> To Version 8.0.0-alpha.1.22602.2 Dependency coherency updates Microsoft.NET.Sdk.WindowsDesktop From Version 8.0.0-alpha.1.22551.2 -> To Version 8.0.0-alpha.1.22601.6 (parent: Microsoft.WindowsDesktop.App.Ref

akoeplinger · 2022-12-02T16:58:51Z

@marcpopMSFT we're back to the nuget error now:

C:\h\w\B7D909EB\t\dotnetSdkTests\hbf5fo2n.ikh\It_errors_whe---88229FEB\MissingTargetPlatform\MissingTargetPlatform.csproj : error NU1012: Platform version is not present for one or more target frameworks, even though they have specified a platform: net8.0-custom

…confusing

marcpopMSFT · 2022-12-02T18:19:37Z

I pushed a fix for the test but that test is now pretty wonky. @nkolev92 @dsplaisted The test (It_errors_when_missing_windows_target_platform) sets the TPI to be "custom". I don't know what changed but nuget flags this with error NU1012: Platform version is not present for one or more target frameworks, even though they have specified a platform: net7.0-custom.

If I skip the restore, I get NETSDK1140: 0.0 is not a valid TargetPlatformVersion for custom. Valid versions include as we end up setting the TPV as 0.0`. Only if I also set a TPM directly in the test can I avoid both messages. The original message NETSDK1136 is the most user friendly of the three but I'm not sure a customer will ever hit it as something changed in the order that all these checks run. For now I have the test working as it shouldn't block this PR but open to suggestions on how we should fix this.

dreddy-work · 2022-12-02T19:31:44Z

Hurray!!!

dotnet-issue-labeler bot added the Area-CodeFlow label Nov 4, 2022

dotnet-maestro bot added 4 commits November 5, 2022 12:22

nagilson approved these changes Nov 21, 2022

View reviewed changes

nagilson enabled auto-merge November 21, 2022 17:09

Update VS version.

f27b551

Update the short name of NUnit Playwright in approvals

e914c97

vlada-shubina requested a review from a team as a code owner December 1, 2022 12:17

rainersigwald mentioned this pull request Dec 1, 2022

Update SDK to 8.0.100-alpha.1.22601.6 dotnet/wpf#7336

Merged

Fix test by not restoring and avoiding a different error that's more …

93822ea

…confusing

nagilson merged commit 90fee31 into main Dec 2, 2022

nagilson deleted the darc-main-cba43370-a8a8-4e25-9052-b19c2513de7e branch December 2, 2022 19:30

ViktorHofer mentioned this pull request Oct 19, 2023

[main] Update dependencies from dotnet/windowsdesktop #36125

Merged

[main] Update dependencies from dotnet/windowsdesktop #28897

[main] Update dependencies from dotnet/windowsdesktop #28897

Conversation

dotnet-maestro bot commented Nov 4, 2022 • edited

Coherency Updates

From https://github.com/dotnet/windowsdesktop

dotnet-maestro bot commented Nov 4, 2022

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

dotnet-maestro bot commented Nov 5, 2022

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

dotnet-maestro bot commented Nov 5, 2022

Notification for subscribed users from https://github.com/dotnet/windowsdesktop:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

v-wuzhai commented Nov 9, 2022

azure-pipelines bot commented Nov 9, 2022

v-wuzhai commented Nov 9, 2022

dreddy-work commented Nov 10, 2022

RussKie commented Nov 10, 2022

rchauhan18 commented Nov 10, 2022

marcpopMSFT commented Nov 10, 2022

nagilson commented Nov 21, 2022

nagilson commented Nov 21, 2022

azure-pipelines bot commented Nov 21, 2022

dreddy-work commented Nov 21, 2022

dreddy-work commented Nov 21, 2022

dreddy-work commented Nov 21, 2022

dreddy-work commented Nov 21, 2022

marcpopMSFT commented Nov 21, 2022

dreddy-work commented Nov 21, 2022

marcpopMSFT commented Nov 21, 2022

marcpopMSFT commented Nov 30, 2022

marcpopMSFT commented Nov 30, 2022

rainersigwald commented Nov 30, 2022

rainersigwald commented Nov 30, 2022

nkolev92 commented Nov 30, 2022

rainersigwald commented Nov 30, 2022

vlada-shubina commented Dec 1, 2022 • edited

dreddy-work commented Dec 1, 2022

joeloff commented Dec 1, 2022

joeloff commented Dec 1, 2022

rainersigwald commented Dec 1, 2022

rainersigwald commented Dec 1, 2022

ViktorHofer commented Dec 1, 2022 • edited

rainersigwald commented Dec 1, 2022

marcpopMSFT commented Dec 1, 2022

rainersigwald commented Dec 1, 2022

rainersigwald commented Dec 1, 2022

joeloff commented Dec 1, 2022

akoeplinger commented Dec 2, 2022

akoeplinger commented Dec 2, 2022

marcpopMSFT commented Dec 2, 2022

dreddy-work commented Dec 2, 2022

dotnet-maestro bot commented Nov 4, 2022 •

edited

vlada-shubina commented Dec 1, 2022 •

edited

ViktorHofer commented Dec 1, 2022 •

edited