Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dotnet publish use Release by default in 8.0+ Projects #29155

Merged
merged 74 commits into from
Jan 27, 2023
Merged

Make dotnet publish use Release by default in 8.0+ Projects #29155

merged 74 commits into from
Jan 27, 2023

Commits on Nov 22, 2022

  1. First attempt at implementing default release behavior

    @nagilson
    nagilson committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    fef73a3 View commit details
    Browse the repository at this point in the history

  2. Basic case is working.

    @nagilson
    nagilson committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    b897115 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Add test for failing if conflicting (need asset) AND fix logic

    @nagilson
    nagilson committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    1657da1 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Improve test quality

    @nagilson
    nagilson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0d5d088 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Update the name of some publish release and pack release related strings

    @nagilson
    nagilson committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0ed140f View commit details
    Browse the repository at this point in the history

  2. Move the pack error to a place where it'll actually trigger and fix r… 

    …emaining p*release tests.
    @nagilson
    nagilson committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d67c269 View commit details
    Browse the repository at this point in the history

  3. Remove the publishsinglefileError that I somehow added -- don't know … 

    …how that got there
    @nagilson
    nagilson committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f2d81f0 View commit details
    Browse the repository at this point in the history

  4. Make tests that demonstrate the new default behavior

    @nagilson
    nagilson committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    de55192 View commit details
    Browse the repository at this point in the history

  5. Add test for pack release multi-targeting. Publishing with multi-targ… 

    …eting has been broken since at least net 5.0 so not doing that.
    @nagilson
    nagilson committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0b7520e View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Use simple identifier for the test 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    954ce09 View commit details
    Browse the repository at this point in the history

  2. Use specialized asserts instead of asset.true 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d0dcfa1 View commit details
    Browse the repository at this point in the history

  3. Simplify a pack release test identifier 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e7d07d2 View commit details
    Browse the repository at this point in the history

  4. use path.combine instead of string concat in pack release test 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8be1cbd View commit details
    Browse the repository at this point in the history

  5. Respond to some basic pr feedback about tests and tmp files

    @nagilson
    nagilson committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9e6e28e View commit details
    Browse the repository at this point in the history

  6. Respond to all of the 'nits' before the more substantive issues

    @nagilson
    nagilson committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    390f985 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Consider multi-targeted projects with inherit implicit p*release conf… 

    …licts
    @nagilson
    nagilson committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    890169f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. [WIP] Add test infra code to create test solutions

    @nagilson
    nagilson committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    be3728c View commit details
    Browse the repository at this point in the history

  2. Clean-up test code regarding TestSolution.cs

    @nagilson
    nagilson committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    7d897c7 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'primary/main' into nagilson-publish-rel… 

    …ease-default
    @nagilson
    nagilson committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    65e819c View commit details
    Browse the repository at this point in the history

  4. Merge with main

    @nagilson
    nagilson committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    cc99dc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Fail even if P*Release not defined, and enable PackRelease regardless… 

    … of TFM to avoid multi-targeting multi-target sln
    @nagilson
    nagilson committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e2616d8 View commit details
    Browse the repository at this point in the history

  2. [WIP] check the target framework in a better way

    @nagilson
    nagilson committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    b303257 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Move PublishRelease default to a new area so it can be picked up in p… 

    …re-evaluation. Remove TFM Parsing from CLI code, but inject it into global properties so the TFM in pre-evaluation is correct.
    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    cb7f0b1 View commit details
    Browse the repository at this point in the history

  2. Update solution tests to use correct identifier syntax

    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    983e49e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'nagilson-publish-release-default' of https://github.com… 

    …/nagilson/sdk into nagilson-publish-release-default
    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    09e53a5 View commit details
    Browse the repository at this point in the history

  4. Do PublishRelease error only if IsPublishing so we don't fail VS publish

    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    12557b8 View commit details
    Browse the repository at this point in the history

  5. Make it so the P*Release errors dont occur if env-var opt out enabled.

    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d140c91 View commit details
    Browse the repository at this point in the history

  6. Cleanup code and add the names of a TON of edge cases in tests with m… 

    …ulti target multi project solution publish or pack
    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    aac4107 View commit details
    Browse the repository at this point in the history

  7. Make the code build before finishing tests

    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    025aec4 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'primary/main' into nagilson-publish-rel… 

    …ease-default
    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    57844da View commit details
    Browse the repository at this point in the history

  9. update xlf post merge of PR and ILLink error conflict

    @nagilson
    nagilson committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2f0fcc2 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Update tests and fix bug where the solution arbitrary project not def… 

    …inining publishrelease would not error
    @nagilson
    nagilson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    e36427a View commit details
    Browse the repository at this point in the history

  2. Consider that the filepath of project is not a fullpath

    @nagilson
    nagilson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    98fa0e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. [WIP] Fix some of the newly added PublishRelease tests

    @nagilson
    nagilson committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    3a3d4a0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Merge branch 'main' into nagilson-publish-release-default

    @nagilson
    nagilson committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    2f7c1d3 View commit details
    Browse the repository at this point in the history

  2. .WithTargetframeworks uses Targetframeworks instead of TargetFramewor… 

    …k, And Dont error with conflict PublishRelease if --configuration added
    @nagilson
    nagilson committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1bb42a1 View commit details
    Browse the repository at this point in the history

  3. Fix a bug I added trying to simplify code where publish command parse… 

    …r was used for pack
    @nagilson
    nagilson committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    466b909 View commit details
    Browse the repository at this point in the history

  4. CONSIDER: 1 Project Turns Into 9 Evaluations With Pack Multitarget ->… 

    … Move PackRelease Default to Sdk.Props to be correct in this case
    @nagilson
    nagilson committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    ec10854 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Make publish tests with Debug hardcoded use Release. Code cleanup.

    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    ccda58c View commit details
    Browse the repository at this point in the history

  2. Fix some more tests expecting publish debug

    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0638edc View commit details
    Browse the repository at this point in the history

  3. Clean-up publishrelease default code again before review, anticipatin… 

    …g review feedback.
    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    44b2397 View commit details
    Browse the repository at this point in the history

  4. Make error message not say use Directory.Build.props because it doesn… 

    …'t work
    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    1fc9949 View commit details
    Browse the repository at this point in the history

  5. Remove quotes from error message

    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b3a342e View commit details
    Browse the repository at this point in the history

  6. UCR test to use release config instead of debug

    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    eb32cf3 View commit details
    Browse the repository at this point in the history

  7. PublishRelease only affects publish test change

    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    bfd1f90 View commit details
    Browse the repository at this point in the history

  8. Fix solution handling code to not undefine properties if not set

    @nagilson
    nagilson committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    80b58d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Fix some crappy code in .net tool pack test per @dsplaisted where mul… 

    …titargeting test code didnt give TFM
    @nagilson
    nagilson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0447d59 View commit details
    Browse the repository at this point in the history

  2. Revert back to the old error message

    @nagilson
    nagilson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f3fc8d6 View commit details
    Browse the repository at this point in the history

  3. [!] Change the design to be slower but break less customers.

    @nagilson
    nagilson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c301b25 View commit details
    Browse the repository at this point in the history

  4. Update one remaining test to reflect new change that fails less often

    @nagilson
    nagilson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    66b69bb View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Respond to PR feedback and add the slow and fast way as a flag

    @nagilson
    nagilson committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    be4ef83 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'primary/main' into nagilson-publish-rel… 

    …ease-default
    @nagilson
    nagilson committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    90ed485 View commit details
    Browse the repository at this point in the history

  3. Remove test with the old environment variable idea.

    @nagilson
    nagilson committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    baa0905 View commit details
    Browse the repository at this point in the history

  4. Remove the test solution files and update tests

    @nagilson
    nagilson committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d94f360 View commit details
    Browse the repository at this point in the history

  5. Clean up remaining tests with removed solution file gunk code that ca… 

    …n be auto-generated by new testsolution library
    @nagilson
    nagilson committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    59abc25 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Improve comment clarity by removing TFM and making it TargetFramework 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2523195 View commit details
    Browse the repository at this point in the history

  2. Respond to PR feedback -> improve comments regarding PublishRelease, … 

    …and don't deny custom Configurations anymore.
    @nagilson
    nagilson committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9803137 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'nagilson-publish-release-default' of https://github.com… 

    …/nagilson/sdk into nagilson-publish-release-default
    @nagilson
    nagilson committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    168a0dd View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Make a comment point to what MSBuild code it is relying oon 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    47a78ee View commit details
    Browse the repository at this point in the history

  2. Use Assert.Equal instead of Assert.True == 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    693546c View commit details
    Browse the repository at this point in the history

  3. Use Path.Combine instead of str + str 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    af4eb20 View commit details
    Browse the repository at this point in the history

  4. Remove the "v" that was supposed to be a down arrow in the comment 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    ebf7fea View commit details
    Browse the repository at this point in the history

  5. Update parameter name to reflect the pass by reference default of C# 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    fda2de8 View commit details
    Browse the repository at this point in the history

  6. Be clear that Configuration > PublishRelease or PackRelease in the er… 

    …ror message.

Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    d057474 View commit details
    Browse the repository at this point in the history

  7. Check that FileInfo exists instead of using Assert.True(File.Exists..… 

    ….) not actually sure why we are doing this one

Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    66e4967 View commit details
    Browse the repository at this point in the history

  8. Do FileInfo asserts because they give the path if they fail 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    a353113 View commit details
    Browse the repository at this point in the history

  9. Fix a small typo in the test name 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    51e4385 View commit details
    Browse the repository at this point in the history

  10. Use Tuples with named elements instead of a Tuple<K, V> 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    951e941 View commit details
    Browse the repository at this point in the history

  11. Use named tuples over Tuple<> 

    Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
    @nagilson @dsplaisted
    nagilson and dsplaisted committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0c7d76f View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Respond to PR feedback to improve code quality

    @nagilson
    nagilson committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    26e5f57 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'nagilson-publish-release-default' of https://github.com… 

    …/nagilson/sdk into nagilson-publish-release-default
    @nagilson
    nagilson committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    71902de View commit details
    Browse the repository at this point in the history

  3. Update XLF

    @nagilson
    nagilson committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    905b44b View commit details
    Browse the repository at this point in the history

  4. Respond to PR feedback to improve test code quality for publishrelease

    @nagilson
    nagilson committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3d70802 View commit details
    Browse the repository at this point in the history

  5. Remove the / in a test that would fail because paths in linux are dif… 

    …ferent than win
    @nagilson
    nagilson committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    d6e4e38 View commit details
    Browse the repository at this point in the history