Fix bug with dotnet publish -p:Foo
#30265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens to a property such as this when it gets to the MSBuild property parsing? Should we consider this for 7.0 servicing (or at least 7.0.300)? |
kasperk81
reviewed
Feb 1, 2023
|
@dsplaisted That's a good question... looks like MSBuild undefines it. I will change this code to account for this. Need to check if |
dsplaisted
approved these changes
Feb 2, 2023
nagilson
commented
Feb 2, 2023
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Show resolved
Hide resolved
baronfel
approved these changes
Feb 2, 2023
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Outdated
Show resolved
Hide resolved
nagilson
force-pushed
the
nagilson-bad-msbuild-property-failure
branch
from
00a228a
to
c2504ab
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just discovered this on my own testing ... since NET 7 there has been a invalid index exception which occurs when you
packorpublishand give an incomplete property key value pair, such asdotnet publish -p:Foo. This fixes said error. In NET 6 it was a no op to do this.