Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 30369 enable docker build platform switch #30762

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

JL03-Yue
Copy link
Member

Issue #30369:
translate RID in -r /amd64 to /x64
translate arch in -a amd64 to x64

@dsplaisted
Copy link
Member

@JL03-Yue Reading through #30369, it looks like the -a and --arch parameters are missing from dotnet restore. Can you look at adding those together with this PR?

@richlander As implemented here, this will also translate the architecture from amd64 to x64 for Windows or other RIDs. It's a lot easier to implement that way. Does that sound OK?

@richlander
Copy link
Member

richlander commented Feb 21, 2023

Right. That sounds good.

This PR has a dependency on this change and includes some test cases.

If you give me an SDK build (preferably for Linux), I can try it.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very happy to have this in!

@JL03-Yue JL03-Yue merged commit 69db8f9 into dotnet:main Feb 24, 2023
@richlander
Copy link
Member

What is the easiest way for me to get a build to test this?

So nice to see this!!!

@baronfel
Copy link
Member

@richlander least-effort is probably going to be to wait a couple days for the codeflow to dotnet/installer, then grab an 8.0 preview installer from there. Fastest turnaround would be stitching your own SDK together by:

  • building this repo locally with ./build.[cmd|sh]
  • take the .\artifacts\bin\redist\Debug\dotnet\sdk\8.0.100-dev\dotnet.dll that results and copy it over dotnet.dll from a different, already-installed 8.0 nightly preview SDK
  • ???
  • profit

@richlander
Copy link
Member

I love least effort. I will just try once a day starting Monday and we will see when the change shows up.

Once I have validated it work, let's start talking about the 7.0 back port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants