-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 30369 enable docker build platform switch #30762
Conversation
@JL03-Yue Reading through #30369, it looks like the @richlander As implemented here, this will also translate the architecture from amd64 to x64 for Windows or other RIDs. It's a lot easier to implement that way. Does that sound OK? |
Right. That sounds good. This PR has a dependency on this change and includes some test cases. If you give me an SDK build (preferably for Linux), I can try it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, very happy to have this in!
What is the easiest way for me to get a build to test this? So nice to see this!!! |
@richlander least-effort is probably going to be to wait a couple days for the codeflow to dotnet/installer, then grab an 8.0 preview installer from there. Fastest turnaround would be stitching your own SDK together by:
|
I love least effort. I will just try once a day starting Monday and we will see when the change shows up. Once I have validated it work, let's start talking about the 7.0 back port. |
Issue #30369:
translate RID in -r /amd64 to /x64
translate arch in -a amd64 to x64