Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to read assets cache file the first time it's written #3284

Merged
merged 1 commit into from May 31, 2019
Merged

Fix failure to read assets cache file the first time it's written #3284

merged 1 commit into from May 31, 2019

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented May 31, 2019 •
edited by nguerrera

Fixes issue reported by @nguerrera, introduced in #3268:

Seeing message NETSDK1062: Unable to use package assets cache due to I/O error. This can occur when the same project is built more than once in parallel. Performance may be degraded, but the build result will not be impacted. [D:\Temp\demo\demo.csproj]

Looks like the change you made has the file still open for write when we try to read it back on first build.

Can you take a look, this will be a significant perf regression in preview 6

Fix #3287

@dsplaisted dsplaisted requested review from a team and nguerrera May 31, 2019 06:47
@dsplaisted
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nguerrera nguerrera mentioned this pull request May 31, 2019
Closed
@dsplaisted dsplaisted merged commit 2091d9e into dotnet:master May 31, 2019
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
@dotnet-maestro
[master] Update dependencies from aspnet/AspNetCore (dotnet#3284)
2dd19c9 
* Update dependencies from https://github.com/aspnet/AspNetCore build 20191023.2

- Microsoft.AspNetCore.DeveloperCertificates.XPlat - 5.0.0-alpha1.19523.2

* Update dependencies from https://github.com/aspnet/AspNetCore build 20191023.3

- Microsoft.AspNetCore.DeveloperCertificates.XPlat - 5.0.0-alpha1.19523.3

* Update dependencies from https://github.com/aspnet/AspNetCore build 20191023.10

- Microsoft.AspNetCore.DeveloperCertificates.XPlat - 5.0.0-alpha1.19523.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguerrera nguerrera nguerrera approved these changes

@peterhuene peterhuene peterhuene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting package assets cache messages on build with the latest master bits
3 participants
@dsplaisted @nguerrera @peterhuene