Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add devcontainer support #37412

Merged
merged 16 commits into from Mar 11, 2024
Merged

add devcontainer support #37412

merged 16 commits into from Mar 11, 2024

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Dec 9, 2023

fixes #21299

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member labels Dec 9, 2023
@WeihanLi WeihanLi marked this pull request as ready for review December 9, 2023 07:48
@WeihanLi
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 37412 in repo dotnet/sdk

baronfel
baronfel approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for adding it, it'll be great to have a ready to go dev environment for this repo.

.devcontainer/scripts/post-creation.sh Show resolved Hide resolved
@baronfel baronfel enabled auto-merge (squash) February 21, 2024 18:43
@WeihanLi
Copy link
Contributor Author

@baronfel @nagilson could you please help try to rerun the CI build, seemed the failed test case is not related
image

@baronfel
Copy link
Member

That test in particular has been failing very often today.

@WeihanLi
Copy link
Contributor Author

That test in particular has been failing very often today.

failed again 😢

@baronfel
Copy link
Member

@dotnet/razor-compiler is there a known issue with Razor? This test has been failing on multiple SDK CI flows today.

@baronfel baronfel enabled auto-merge (squash) February 22, 2024 02:43
@jjonescz
Copy link
Contributor

tracking the razor issue here as it affects many (all?) PRs: #38942

auto-merge was automatically disabled February 23, 2024 04:45

Head branch was pushed to by a user without write access

@baronfel baronfel enabled auto-merge (squash) February 23, 2024 18:53
@nagilson
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nagilson
Copy link
Member

New failure across the repo, it is not related to your change. Hope we fixed it, but we will see

@baronfel
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@baronfel baronfel merged commit be2654e into dotnet:main Mar 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

@nagilson nagilson nagilson left review comments

Assignees
No one assigned
Labels
Area-Containers Related to dotnet SDK containers functionality untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for codespaces
4 participants
@WeihanLi @baronfel @jjonescz @nagilson