Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.3xx] Update dependencies from microsoft/vstest #37983

Merged
merged 19 commits into from
Jan 30, 2024
Merged

[release/8.0.3xx] Update dependencies from microsoft/vstest #37983

merged 19 commits into from
Jan 30, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 12, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/microsoft/vstest

  • Subscription: 6c7dd322-4893-4d29-8bf2-08dc11e0a92e
  • Build: 20240130.1
  • Date Produced: January 30, 2024 11:54:27 AM UTC
  • Commit: d61759559535f43790211fa53be7829dfe598841
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
4016f89 
…240112.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24062-01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jan 12, 2024
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
9384a8e 
…240112.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24062-01
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
b25b3fe 
…240112.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24062-01
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
9027190 
…240114.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24064-01
@v-wuzhai v-wuzhai requested a review from a team January 16, 2024 09:23
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
c67792a 
…240115.5

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24065-05
@mthalman
Copy link
Member

Error for source build:

/__w/1/s/artifacts/source-build/self/src/src/Layout/redist/redist.csproj : error NU1202: Package Microsoft.TestPlatform.Build 17.10.0-preview-24065-05 is not compatible with net8.0 (.NETCoreApp,Version=v8.0). Package Microsoft.TestPlatform.Build 17.10.0-preview-24065-05 supports: net9.0 (.NETCoreApp,Version=v9.0) [/__w/1/s/artifacts/source-build/self/src/source-build.slnf]

I'm investigating.

@mthalman
Copy link
Member

So these changes are updating VS Test version in 8.0.3xx from 17.9 to 17.10. The issue is that 17.10 has been source built, targeting net9.0, from an Arcade update: microsoft/vstest#4795. The tension here is between 17.10 of VS Test flowing to SDK in both 8.0.3xx (which needs net8.0) and main (which needs net9.0).

@MichaelSimons - Any ideas on how to resolve this?

cc @Evangelink

@MichaelSimons
Copy link
Member

@MichaelSimons - Any ideas on how to resolve this?

I think a pattern like what Roslyn implemented is what is needed here. The repo source-build builds of vstest need to multi-target.

@mthalman
Copy link
Member

@Evangelink - Please implement the pattern that was suggested by @MichaelSimons above. You'll need to be targeting both NetCurrent and NetPrevious in the context of source build.

@Evangelink
Copy link
Member

@mthalman What's the deadline for this? I expect this might be quite some work given the structure of vstest.

@mthalman
Copy link
Member

@mthalman What's the deadline for this? I expect this might be quite some work given the structure of vstest.

That's not my call. But this blocks 17.10 from getting into 8.0.3xx. So whenever that is needed, I suppose.

@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
b5868bc 
…240116.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24066-01
@marcpopMSFT
Copy link
Member

17.10 will ship in May with the first preview in Feb. It'd be good to get this resolved by preview 2 in March so I'd aim for getting this fixed by mid-Feb. So you do have some time.

@Evangelink
Copy link
Member

@marcpopMSFT Awesome! I will work on the fix next week. I am just really busy with other prios this week and was afraid I wouldn't manage to have it done soon enough for you. Feel free to assign that to me.

@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
e0e225c 
…240117.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24067-01
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
ce2636a 
…240118.2

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24068-02
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
20240f3 
…240119.4

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24069-04
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
88af623 
…240119.4

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24069-04
@nohwnd nohwnd mentioned this pull request Jan 22, 2024
Closed
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
ada1bad 
…240119.4

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24069-04
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
5bd532c 
…240122.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24072-01
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
26b2002 
…240123.2

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24073-02
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
d9c6d23 
…240123.2

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24073-02
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
4c91f79 
…240123.2

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24073-02
@Evangelink
Copy link
Member

Sorry for the delay here, this will be on top of my list for Monday.

@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
ee08e89 
…240126.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24076-01
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
eca72f1 
…240126.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24076-01
@Evangelink Evangelink mentioned this pull request Jan 29, 2024
Merged
@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
be2ff37 
…240128.3

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24078-03
@Evangelink
Copy link
Member

I have started this PR microsoft/vstest#4856 but honestly nothing makes sense with source-build so if someone wants to take it over or provide some guidance, that would be lovely.

@Evangelink
Copy link
Member

Related PR is finally green, waiting for some approval and to flow down here. Hopefully this will be good today.

@dotnet-maestro
Update dependencies from https://github.com/microsoft/vstest build 20…
51923dc 
…240130.1

Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI
 From Version 17.9.0-release-23627-01 -> To Version 17.10.0-preview-24080-01
@Evangelink
Copy link
Member

I have restarted the failed job. The error looks unrelated to VSTest.

@marcpopMSFT
Copy link
Member

The only failure is a known issue for a test that has been disabled: #38268 I'll go ahead and merge on red.

@marcpopMSFT marcpopMSFT merged commit 8d38bc1 into release/8.0.3xx Jan 30, 2024
16 of 20 checks passed
@marcpopMSFT marcpopMSFT deleted the darc-release/8.0.3xx-ee798d06-529d-4156-a829-d6b340a5fd21 branch January 30, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

Assignees

@Evangelink Evangelink

Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mthalman @MichaelSimons @Evangelink @marcpopMSFT