Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VMR] Publish scenario test results only when available #40903

Merged
merged 1 commit into from
May 15, 2024

Conversation

akoeplinger
Copy link
Member

#40860 wasn't enough, there are more cases when scenario tests are skipped:

<!-- Skip scenario tests if the host architecture is different from the target architecture since the tests
require the ability to execute the built SDK. But the CLI is not capable of running on a host with a
different architecture (i.e. "cannot execute binary file: Exec format error"). -->
<_RunScenarioTests Condition="'$(BuildArchitecture.ToLowerInvariant())' != '$(TargetArchitecture.ToLowerInvariant())'">false</_RunScenarioTests>
<!-- Skip scenario tests if the portable OS (determined from the host machine) is different from the target OS
since the tests require the ability to execute the built SDK. An example of where this would be disabled is
cross-build of using Mariner to build for Alpine (linux vs linux-musl). -->
<_RunScenarioTests Condition="'$(BuildOS)' != 'windows' and '$(DotNetBuildSourceOnly)' != 'true' and '$(__PortableTargetOS.ToLowerInvariant())' != '$(TargetOS.ToLowerInvariant())'">false</_RunScenarioTests>
<!-- The scenario tests are not supported when unofficial build versioning is used. -->
<_RunScenarioTests Condition="'$(UseOfficialBuildVersioning)' == 'false'">false</_RunScenarioTests>

Check whether we have artifacts and set an AzDO variable instead.

#40860 wasn't enough, there are more cases when scenario tests are skipped:
https://github.com/dotnet/sdk/blob/85b4f738a25e83e6456d813ad3e139b2a854eb7f/src/SourceBuild/content/test/tests.proj#L6-L17

Check whether we have artifacts and set an AzDO variable instead.
@akoeplinger akoeplinger requested review from a team as code owners May 15, 2024 14:11
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels May 15, 2024
@akoeplinger akoeplinger merged commit ffdc450 into main May 15, 2024
24 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-1 branch May 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants