Reenable TemplateEngine tests #42267
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
I'm not sure this is a good long-term strategy, this package is being updated regularly so we'll run into this again in the future: I checked some of the other tests and they mostly use packages that haven't been updated in years, maybe we should just switch to one of these? |
|
looks like there is already a fixed version test: https://github.com/dotnet/sdk/blob/main/test/dotnet-new.Tests/DotnetNewDetailsTest.Approval.cs#L47 |
|
Yeah, the test is supposed to test not passing a version but I think that won't really work with a package that is frequently updated. In other tests we use |
...sts/Approvals/DotnetNewDetailsTest.CanDisplayDetails_InstalledPackage_OtherFeed.verified.txt
Outdated
Show resolved
Hide resolved
| Package version: 4.0.3038 | ||
| Details: Collection of templates for Azure Functions | ||
| NUnit3.DotNetNew.Template | ||
| Package version: 1.9.0 |
There was a problem hiding this comment.
Is there any way to change the test comparison logic to not actually check the details and package version? If we don't control the template, those could change at any time and break the test (even if we do control it, it might need to change). Having a test gate on a dynamic set of values like that is not great.
There was a problem hiding this comment.
I noticed that almost all the test failures are due to version issues, so we can simply check if it is the latest version.
| throw new Exception("No versions found."); | ||
| } | ||
|
|
||
| return versions.Last(); |
There was a problem hiding this comment.
FYI the last entry is not necessarily the latest stable version, e.g. when we have previews, but looks like we don't need to care about that since templates don't support preview versions: dotnet/templating#1423
fixes: #42260