Remove the install of all runtimes 5.0 and below. #42327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve any tests that required these runtimes to be installed. We will still likely keep a few tests targeting older runtimes just in case but for now, this cleans up some of the extra installs and will save time when running builds.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
@v-wuzhai mind updating my branch to remove any tests that fail because of this removal? We're still discussing whether we want to remove all of the tests targeting old runtimes (we don't want the SDK to break but all of these have been out of support for over a year at this point and many longer than that). There's less value in including these in our tests as the number of customers targeting these still is much smaller these days. At the very least, getting rid of the install should speed up our builds slightly and reduce our overall size on disk in our builds. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should then remove any tests that required these runtimes to be installed.
We will still likely keep a few tests targeting older runtimes just in case but for now, this cleans up some of the extra installs and will save time when running builds.