Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NETStandard.Library implicit package reference version to 1.6.1 #582

Merged
merged 5 commits into from Jan 6, 2017

Conversation

dsplaisted
Copy link
Member

@gulbanana
Copy link

note that this will lead to using the version of System.Net.Http from NETStandard.Library, which will trigger https://github.com/dotnet/corefx/issues/11100

@qmfrederik
Copy link

@dsplaisted I built this PR locally and tried to build my project which references NETStandard.Library for net462, but I still get this issue when building locally:

13:32:20.821   4:2>ResolveAssemblyReferences: (TargetId:35)
                         Required by "C:\Users\Frederik Carlier\Source\Repos\Quamotion\src\Nttr.RTK.Thrift\bin\Debug\net462\Nttr.RTK.Thrift.dll". (TaskId:15)
                         Required by "C:\Users\Frederik Carlier\.nuget\packages\thrift\0.9.1.3\lib\net35\Thrift.dll". (TaskId:15)
                         This reference is not "CopyLocal" because at least one source item had "Private" set to "false" and no source items had "Private" set to "true". (TaskId:15)
                         The ImageRuntimeVersion for this reference is "v4.0.30319". (TaskId:15)
                     There was a conflict between "System.Runtime, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" and "System.Runtime, Version=4.0.20.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". (TaskId:15)
13:32:21.133   4:2>C:\Program Files\dotnet\sdk\1.0.0-preview5-004275\Microsoft.Common.CurrentVersion.targets(1909,5): warning MSB3243: No way to resolve conflict between "System.Runtime, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" and "System.Runtime, Version=4.0.20.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a". Choosing "System.Runtime, Version=4.1.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" arbitrarily. [C:\Users\Frederik Carlier\Source\Repos\Quamotion\src\Quamotion.Devices\Quamotion.Devices.Core.csproj]

I'm using version 1.0.0-preview5-004275 of the CLI, built this patch using build.cmd and copied the content of the bin\Debug\Packages\Microsoft.NET.Sdk.1.0.0-alpha-00000001-01.nupkg file to C:\Program Files\dotnet\sdk\1.0.0-preview5-004275\Sdks\Microsoft.NET.Sdk

Not sure if just copying the output of a SDK build to the CLI folder is supposed to work, but thought I'd let you know. (I did notice the side-effects of the implicit includes so at least some of the changes to the SDK propagated correctly to my local build environment)

@qmfrederik
Copy link

@dsplaisted Ah, just noticed that these are warnings, not errors, and the build did in fact succeed. Great! So dotnet �publish now works! Looking forward to a daily cli build with this change, would be extremely helpful!

(Take the three exclamation marks as an expression of my relief that this is now working ;-))

<Reference Include="System.IO.Compression" Condition=" '$(_TargetFrameworkVersionWithoutV)' >= '4.5' "/>
<Reference Include="System.Net.Http" Condition=" '$(_TargetFrameworkVersionWithoutV)' >= '4.5' "/>

<!-- Don't automatically reference System.IO.Compression or System.Net.Http to help avoid hitting https://github.com/Microsoft/msbuild/issues/1329. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intend to add these back? can you file an issue for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #594

============================================================
-->

<!-- Override the ImplicitlyExpandDesignTimeFacades target with a fix for https://github.com/Microsoft/msbuild/issues/1345 until
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again please file a bug on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed #595 for this

@dsplaisted dsplaisted merged commit 7eb264f into dotnet:master Jan 6, 2017
@dsplaisted dsplaisted deleted the update-netstandard-package branch January 6, 2017 02:50
mmitche added a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
…c1-3116-4b4f-aa7e-56f70f827721

[release/3.0.1xx] Update dependencies from aspnet/AspNetCore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referencing NETStandard.Library package version 1.6.1 results in extra files published
5 participants