New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NETStandard.Library implicit package reference version to 1.6.1 #582
Update NETStandard.Library implicit package reference version to 1.6.1 #582
Conversation
…possible to make sense of changes
note that this will lead to using the version of System.Net.Http from NETStandard.Library, which will trigger https://github.com/dotnet/corefx/issues/11100 |
@dsplaisted I built this PR locally and tried to build my project which references NETStandard.Library for net462, but I still get this issue when building locally:
I'm using version Not sure if just copying the output of a SDK build to the CLI folder is supposed to work, but thought I'd let you know. (I did notice the side-effects of the implicit includes so at least some of the changes to the SDK propagated correctly to my local build environment) |
@dsplaisted Ah, just noticed that these are warnings, not errors, and the build did in fact succeed. Great! So (Take the three exclamation marks as an expression of my relief that this is now working ;-)) |
<Reference Include="System.IO.Compression" Condition=" '$(_TargetFrameworkVersionWithoutV)' >= '4.5' "/> | ||
<Reference Include="System.Net.Http" Condition=" '$(_TargetFrameworkVersionWithoutV)' >= '4.5' "/> | ||
|
||
<!-- Don't automatically reference System.IO.Compression or System.Net.Http to help avoid hitting https://github.com/Microsoft/msbuild/issues/1329. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we intend to add these back? can you file an issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #594
============================================================ | ||
--> | ||
|
||
<!-- Override the ImplicitlyExpandDesignTimeFacades target with a fix for https://github.com/Microsoft/msbuild/issues/1345 until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again please file a bug on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've filed #595 for this
…c1-3116-4b4f-aa7e-56f70f827721 [release/3.0.1xx] Update dependencies from aspnet/AspNetCore
ImplicitlyExpandDesignTimeFacades
(from @cdmihai's code here) to workaround ImplicitlyExpandDesignTimeFacades target should only add facades if a higher version isn't already referenced msbuild#1345