Pass the correct delimiter for DefineConstants for C# and VB #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were appending the implicit framework define with a ; in common code. VB needs a ',' as the delimiter.
|
@dotnet/project-system |
mavasani
approved these changes
Jan 17, 2017
nguerrera
approved these changes
Jan 17, 2017
|
Tagging @MattGertz for RTM approval. This unblocks dogfooding by making sure that our VB projects don't break. |
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…0190521.1 (dotnet#652) - Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview6-19271-01 - Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview6-19271-01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were appending the implicit framework define with a ; in common code. VB needs a ',' as the delimiter.
Also removed a workaround we had for building VB projects since the compiler bug has been fixed. The CLI doesn't have the VB compiler and so I can't add a unit test for VB.