Use Microsoft.NETCore.App 1.1.1 when targeting netcoreapp1.1 #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ared runtime unless otherwise specified via RuntimeFrameworkVersion Fixes (half of) dotnet#860
nguerrera
reviewed
Feb 16, 2017
| @@ -68,6 +68,9 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| --> | |||
|
|
|||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'"> | |||
| <!-- If targeting netcoreapp1.1, and RuntimeFrameworkVersion is not specified, use version 1.1.1 --> | |||
| <RuntimeFrameworkVersion Condition="'$(RuntimeFrameworkVersion)' == '' And '$(_TargetFrameworkVersionWithoutV)' == '1.1'">1.1.1</RuntimeFrameworkVersion> | |||
There was a problem hiding this comment.
I thought we were getting away from this. It sucks to have to patch this file whenever there's a patch. Also, given all of the issues with NETStandard.Libary 1.6 -> 1.6.1, I think it would be prudent to get to a place where simply upgrading the SDK never changes your package graph.
|
Why only half? |
srivatsn
approved these changes
Feb 17, 2017
srivatsn
reviewed
Feb 17, 2017
| @@ -68,6 +68,9 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| --> | |||
|
|
|||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'"> | |||
| <!-- If targeting netcoreapp1.1, and RuntimeFrameworkVersion is not specified, use version 1.1.1 --> | |||
There was a problem hiding this comment.
Let's add a better comment here explaining why we are doing this.
|
@MattGertz for approval Scenario
BugWorkaroundsSet RiskLow Performance ImpactLow Regression AnalysisNot a regression |
Update tests and add comment about the RuntimeFrameworkVersion selection logic. Update version of the CLI we use so that it will have 1.0.4 and 1.1.1 for our tests to run with.
nguerrera
approved these changes
Feb 18, 2017
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…0190814.8 (dotnet#878) - Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview9.19414.8 - Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview9.19414.8 - Microsoft.AspNetCore.Analyzers - 3.0.0-preview9.19414.8 - Microsoft.AspNetCore.Components.Analyzers - 3.0.0-preview9.19414.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting netcoreapp1.1, use version 1.1.1 of the package and shared runtime unless otherwise specified via RuntimeFrameworkVersion
Fixes (half of) #860