Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit code 0 when no files found to sign #197

Closed
AArnott opened this issue Mar 9, 2020 · 1 comment · Fixed by #202
Closed

Exit code 0 when no files found to sign #197

AArnott opened this issue Mar 9, 2020 · 1 comment · Fixed by #202
Labels
enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors

Comments

@AArnott
Copy link
Contributor

AArnott commented Mar 9, 2020

When the .nupkg file is not where I indicate it should be found:

dotnet tool run SignClient -- sign --baseDirectory D:\git\Nerdbank.GitVersioning\bin\Nerdbank.GitVersioning.Tasks\Release --input "*.nupkg" ...

The tool simply returns with exit code 0 and does not emit any warning whatever. Yet surely if I invoke the tool and it signs nothing, that's a cause for concern, is it not?

Shouldn't the tool write a warning to stderr and return a non-zero exit code?
@clairernovotny
Copy link
Member

Good point, signing nothing is probably flag that the inputs weren't correctly found.

Any chance you can submit a PR?

@clairernovotny clairernovotny added enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors labels Mar 9, 2020
AArnott added a commit to AArnott/SignService that referenced this issue Mar 14, 2020
@AArnott
Return exit code 3 from SignClient when no files will be signed
f240047 
Fixes dotnet#197
@AArnott AArnott mentioned this issue Mar 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return exit code 3 from SignClient when no files will be signed AArnott/SignService
2 participants
@AArnott @clairernovotny