Add DependencyPackageProjects step to workflow #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
May 16, 2023
| @@ -42,7 +42,7 @@ When generating a package(s), the tooling will detect and generate all dependent | |||
| ``` | |||
|
|
|||
| After generating new reference packages, all new projects must be referenced as a | |||
| [DependencyPackageProjects](https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L10). | |||
| [DependencyPackageProjects](https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props#L9). | |||
There was a problem hiding this comment.
Use a permalink instead? That alleviates the need to maintain it. Also applies to 2nd usage below.
There was a problem hiding this comment.
The downside to a permalink is that a different type of maintenance issue is caused when the documentation this link points to is updated. We want this link to point to the most recent documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed today that there is no DependencyPackageProjects step mentioned in the workflow section. It is mentioned above but it should be included in the workflow.