Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8: Tracking issue for repos specifying and regularly updating their dependencies. #2980

Closed
24 tasks done
mmitche opened this issue Aug 10, 2022 · 7 comments
Closed
24 tasks done
Labels
area-infra Source-build infrastructure and reporting

Comments

@mmitche
Copy link
Member

mmitche commented Aug 10, 2022

Description

This is a repo tracking issue related to #2979. Repositories should:

  • Specify all dependencies produced by source-built repositories in their eng/Version.Details.xml files. They need only specify dependencies for repos that are produced earlier in source build.

They should then either:

Repositories

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member Author

mmitche commented Aug 10, 2022

@MichaelSimons is this assertion correct?

They need only specify dependencies for repos that are produced earlier in source build

@MichaelSimons
Copy link
Member

They need only specify dependencies for repos that are produced earlier in source build

To avoid confusion, it is really for any dependencies produced in source-build. Because there a cycles in the graph, a dependency could be built after. In that case, the dependency gets satisfied by previous source-built artifacts. Even if that is the case, we are building with a recent version and we would like to avoid pinned references in those cases.

@mmitche
Copy link
Member Author

mmitche commented Aug 10, 2022

They need only specify dependencies for repos that are produced earlier in source build

To avoid confusion, it is really for any dependencies produced in source-build. Because there a cycles in the graph, a dependency could be built after. In that case, the dependency gets satisfied by previous source-built artifacts. Even if that is the case, we are building with a recent version and we would like to avoid pinned references in those cases.

We do need to avoid product dependency cycles in order to not break the current official build and staging process. We can have cycles for toolset dependencies, but not for product dependencies. Do you have an example of one of these that exists today that we can analyze a bit?

@MichaelSimons MichaelSimons added area-infra Source-build infrastructure and reporting and removed untriaged labels Aug 11, 2022
@mmitche
Copy link
Member Author

mmitche commented Aug 29, 2022

@MichaelSimons I believe I have all the child issues opened for this work

@mmitche mmitche changed the title .NET: Tracking issue for repos specifying and regularly updating their dependencies. .NET 8: Tracking issue for repos specifying and regularly updating their dependencies. Aug 30, 2022
@MichaelSimons
Copy link
Member

@mmitche - I believe this was done as part of #3043. Can this and all related issues be closed?

@mmitche
Copy link
Member Author

mmitche commented Jun 15, 2023

Yep, that and the prebuilt detection work.

@mmitche mmitche closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
Archived in project
Development

No branches or pull requests

2 participants