Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable individual PackageVersions.props file on tarball-contributing repositories #3043

Closed
26 tasks done
oleksandr-didyk opened this issue Sep 29, 2022 · 2 comments
Closed
26 tasks done

Enable individual PackageVersions.props file on tarball-contributing repositories #3043

oleksandr-didyk opened this issue Sep 29, 2022 · 2 comments
Assignees
@MichaelSimons @NikolaMilosavljevic @oleksandr-didyk
Labels
area-arcade Common Arcade source-build infra

Comments

@oleksandr-didyk
Copy link
Contributor

oleksandr-didyk commented Sep 29, 2022 •
edited by MichaelSimons
Loading

Part of #2482

Given a project-specific PackageVersions.props file (#3041), each of the repositories contributing to the product tarball should opt-in to the new functionality. The opt-in would mean enabling the functionality, building the repository and resolving any issues encountered (investigating if pinned versions can be removed, adding packages to SBRP, etc) together with the repo owners
@oleksandr-didyk oleksandr-didyk added the area-arcade Common Arcade source-build infra label Sep 29, 2022
@oleksandr-didyk oleksandr-didyk self-assigned this Sep 29, 2022
@oleksandr-didyk
Copy link
Contributor Author

oleksandr-didyk commented Sep 29, 2022 •
edited
Loading

Expected implementation time is hard to pin-point due to the number of repositories and the possible issues around enabling the functionality in question. Other tasks, such as #3042, could be performed in parallel to save time

This was referenced Sep 29, 2022
Closed
Closed
@MichaelSimons MichaelSimons assigned mmitche and mthalman and unassigned crummel Mar 28, 2023
@MichaelSimons MichaelSimons mentioned this issue Mar 31, 2023
Merged
This was referenced Mar 31, 2023
Merged
Closed
Merged
This was referenced Apr 5, 2023
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@mthalman mthalman mentioned this issue Apr 13, 2023
Merged
This was referenced May 23, 2023
Merged
Merged
Merged
Merged
@oleksandr-didyk oleksandr-didyk mentioned this issue May 31, 2023
Merged
@MichaelSimons MichaelSimons mentioned this issue May 31, 2023
Merged
@oleksandr-didyk oleksandr-didyk mentioned this issue May 31, 2023
Merged
This was referenced May 31, 2023
Merged
Merged
This was referenced Jun 2, 2023
Merged
Merged
@MichaelSimons MichaelSimons mentioned this issue Jun 2, 2023
Merged
@oleksandr-didyk oleksandr-didyk mentioned this issue Jun 5, 2023
Merged
This was referenced Jun 5, 2023
Merged
Closed
Merged
Merged
@MichaelSimons MichaelSimons mentioned this issue Jun 6, 2023
Merged
rainersigwald pushed a commit to dotnet/msbuild that referenced this issue Jun 7, 2023
@oleksandr-didyk
Add ConfigurationManager to Version.Details (#8818)
855f745 
Contributes to dotnet/source-build#3043

Declaring the `System.Configuration.ConfigurationManager` dependency in `Version.Details.xml` will allow source-build to replace the currently used `7.0.0` version with the `n-1` version coming from previously source-built artifacts in the product / VMR build.

Without this change, once repo PvP is enabled, the source-build of `msbuild` will fail in the product build.
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Jun 8, 2023
Merged
@oleksandr-didyk oleksandr-didyk mentioned this issue Jun 9, 2023
Merged
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Jun 12, 2023
Merged
@oleksandr-didyk oleksandr-didyk mentioned this issue Jun 15, 2023
Merged
@MichaelSimons MichaelSimons mentioned this issue Jun 15, 2023
Closed
24 tasks
@MichaelSimons
Copy link
Member

Closing issue as this has been rolled out to all product repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

@NikolaMilosavljevic NikolaMilosavljevic

@oleksandr-didyk oleksandr-didyk

Labels
area-arcade Common Arcade source-build infra
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@crummel @MichaelSimons @mmitche @NikolaMilosavljevic @mthalman @oleksandr-didyk