Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party dependencies: Build against platform libraries instead of the embedded libraries #89257

Open
dviererbe opened this issue Jul 5, 2023 · 4 comments

Comments

@dviererbe
Copy link
Contributor

On Ubuntu we currently use mostly the embedded libraries included in the source, to build .NET. Optimally we want to use the library packages of the Ubuntu Archive.

A shallow investigation by @mirespace and me showed that there are:

  1. mentioned 3rd party dependencies we could not find in the source; e.g. Slicing-by-8:
  2. references to older versions of 3rd party dependencies; e.g. https://github.com/dotnet/runtime/blob/main/src/coreclr/pal/inc/rt/cpp/xmmintrin.h references llvm-3.9/clang-3.9.1

I have to correct my statement that brotli was modified. There is a diff between the files contained in the repository (here) and the released tarball (here). The release tarball does not contain the files:

  • fuzz/*
  • common/dictionary.bin
  • common/dictionary.bin.br

But, if Microsoft is aware of modified 3rd party dependencies, we should look into getting them merged upstream.

This issue is not mission critical, but long-term we would like to patch the embedded libraries out; I will start a deeper investigation over the next weeks.

Also, @omajid you mentioned in this weeks meeting that there is a flag to enable using the platform libraries. Can you provide more details about that flag?

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 5, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MichaelSimons MichaelSimons removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2023
@MichaelSimons
Copy link
Member

[Triage] There are two parts to this issue. One is on the source-build side around documentation and possibly providing a single option to use the platform libraries. The second part is more specific to the runtime around the specific 3rd party dependencies.

@MichaelSimons
Copy link
Member

Logged dotnet/source-build#3563 to track the source-build side of this. Transferring this to runtime to respond to the specific runtime questions.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 20, 2023
@MichaelSimons MichaelSimons transferred this issue from dotnet/source-build Jul 20, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 20, 2023
@ghost
Copy link

ghost commented Jul 21, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

On Ubuntu we currently use mostly the embedded libraries included in the source, to build .NET. Optimally we want to use the library packages of the Ubuntu Archive.

A shallow investigation by @mirespace and me showed that there are:

  1. mentioned 3rd party dependencies we could not find in the source; e.g. Slicing-by-8:
  2. references to older versions of 3rd party dependencies; e.g. https://github.com/dotnet/runtime/blob/main/src/coreclr/pal/inc/rt/cpp/xmmintrin.h references llvm-3.9/clang-3.9.1

I have to correct my statement that brotli was modified. There is a diff between the files contained in the repository (here) and the released tarball (here). The release tarball does not contain the files:

  • fuzz/*
  • common/dictionary.bin
  • common/dictionary.bin.br

But, if Microsoft is aware of modified 3rd party dependencies, we should look into getting them merged upstream.

This issue is not mission critical, but long-term we would like to patch the embedded libraries out; I will start a deeper investigation over the next weeks.

Also, @omajid you mentioned in this weeks meeting that there is a flag to enable using the platform libraries. Can you provide more details about that flag?

Author: dviererbe
Assignees: -
Labels:

area-Infrastructure, untriaged, needs-area-label

Milestone: -

@marek-safar marek-safar removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 24, 2023
@agocke agocke added this to the Future milestone Sep 26, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants