Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to May 3.1.104 release. #1590

Merged
merged 17 commits into from Jun 1, 2020
Merged

Update to May 3.1.104 release. #1590

merged 17 commits into from Jun 1, 2020

Conversation

crummel
Copy link
Contributor

@crummel crummel commented May 20, 2020

No description provided.

dagood
dagood reviewed May 28, 2020
View reviewed changes
eng/Version.Details.xml Outdated Show resolved Hide resolved
patches/aspnetcore-tooling/0005-remove-unneeded-feeds.patch Show resolved Hide resolved
repos/core-setup.common.props Show resolved Hide resolved
repos/corefx.common.props Show resolved Hide resolved
@dagood
Copy link
Member

dagood commented May 28, 2020 •
edited

The fixup to set SkipSetLastReleasedVersionForSourceBuild means NETStandard.Library.Ref 2.1.0 needs to be in source-build-reference-packages, which it wasn't yet--this caused the bootstrap PR validation to fail. That's in progress over here: dotnet/source-build-reference-packages#118.

(It's expected for all targeting packs to be in SBRP: #1523.)

@crummel crummel requested review from dseefeld and dagood May 30, 2020 18:33
@crummel crummel merged commit 0413210 into dotnet:release/3.1 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omajid omajid omajid left review comments

@dagood dagood dagood approved these changes

@dseefeld dseefeld Awaiting requested review from dseefeld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crummel @dagood @omajid