Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SBRP to version with updated TargetingPacks #1672

Merged
merged 5 commits into from Aug 5, 2020
Merged

Update SBRP to version with updated TargetingPacks #1672

merged 5 commits into from Aug 5, 2020

Conversation

dseefeld
Copy link
Contributor

Fixes #1656

@dseefeld dseefeld requested review from crummel and dagood July 20, 2020 18:40
@dseefeld dseefeld self-assigned this Jul 20, 2020
dagood
dagood requested changes Jul 20, 2020
View reviewed changes
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update dependency?

source-build/eng/Version.Details.xml

Lines 8 to 11 in d9d741a

<Dependency Name="Private.SourceBuild.ReferencePackages" Version="1.0.0-beta.20278.2">
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
<Sha>f3db8b2a4a7c12ac44283b516dac8cda12a5edeb</Sha>
</Dependency>

@dseefeld dseefeld requested a review from dagood July 22, 2020 13:55
dagood
dagood approved these changes Jul 22, 2020
View reviewed changes
tools-local/init-build.proj Outdated Show resolved Hide resolved
omajid
omajid reviewed Jul 22, 2020
View reviewed changes
eng/Version.Details.xml Outdated Show resolved Hide resolved
@dagood dagood mentioned this pull request Jul 29, 2020
Open
@dseefeld
Copy link
Contributor Author

dseefeld commented Aug 5, 2020

OSX smoke test failure is #1685

@dseefeld dseefeld merged commit 514c3ee into dotnet:release/3.1 Aug 5, 2020
@dseefeld dseefeld deleted the updateSBRPVer branch August 5, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omajid omajid omajid left review comments

@crummel crummel crummel approved these changes

@dagood dagood dagood approved these changes

Assignees

@dseefeld dseefeld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

source-build 5.0 includes an asset cache file
4 participants
@dseefeld @omajid @crummel @dagood