New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some minor issues with the bootstrap documentation. #568

Merged

eerhardt merged 1 commit into dotnet:dev/release/2.1 from eerhardt:FixBootstrapDoc

May 22, 2018

Member

eerhardt commented May 21, 2018

There are a couple incorrect things about the bootstrap documentation:

A reference to an option to crossgen the corelib, that doesn't exist. Removed.
Incorrect double dashes in the usage.
A reference to a -config option that doesn't exist.
The example call is incorrect since it doesn't contain the architecture piece of the RID.
1. I also rearranged it so the -release part was first, since this is easy to miss.

/cc @dseefeld @weshaggard @mateusrodrigues


          Fix some minor issues with the bootstrap documentation.

e98b15a

eerhardt requested a review from janvorli

May 21, 2018 22:30

janvorli approved these changes

View reviewed changes

Member

janvorli left a comment

LGTM, thank you for fixing the discrepancies!

dagood approved these changes

View reviewed changes

eerhardt merged commit 776dd5f into dotnet:dev/release/2.1

eerhardt deleted the FixBootstrapDoc branch

May 22, 2018 16:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment