Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dagood NuGet.Client fork to recover commit #94

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Use dagood NuGet.Client fork to recover commit #94

merged 1 commit into from
Aug 8, 2017

Conversation

dagood
Copy link
Member

@dagood dagood commented Aug 7, 2017

The inner FileSystem submodule needs to point to my fork, where I pushed a branch that was deleted.

This fixes the default recursive submodule init experience by making the NuGet.Client submodule's FileSystem submodule have the requested commit available.

Fixes #92

The inner FileSystem submodule needs to point to my fork, where I pushed a branch that was deleted.
@dagood dagood mentioned this pull request Aug 7, 2017
@crummel
Copy link
Contributor

crummel commented Aug 7, 2017

This worked for me.

@dagood
Copy link
Member Author

dagood commented Aug 8, 2017

Is this ok to merge? I'm not familiar with the current state of the master branch.

@omajid
Copy link
Member

omajid commented Aug 8, 2017

+1 for pushing if it makes this repo clone-able :)

@dagood dagood merged commit b914e2f into dotnet:master Aug 8, 2017
@dagood dagood deleted the fix-nuget-filesystem branch August 8, 2017 15:37
@dagood
Copy link
Member Author

dagood commented Aug 8, 2017

Went ahead and merged! Let me know if that helps.

@sergiusens
Copy link
Contributor

I successfully cloned now, thanks

@mishra14
Copy link

@dagood you can switch over to NuGet.Client repo now. We have forked FileSystem and that issue that you were originally facing has been fixed.

@dagood
Copy link
Member Author

dagood commented Oct 12, 2017

Thanks, I'll try submitting a quick submodule switch+update PR, but if there are any issues (e.g. broken patches) I don't plan on working on that right away. (Tracked by #107.)

@omajid
Copy link
Member

omajid commented Oct 12, 2017

We should also pick up a few licensing fixes by switching to NuGet.Client repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants