Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React and Angular project template dependencies #47

Merged
merged 3 commits into from
May 3, 2022

Conversation

MackinnonBuck
Copy link
Member

Summary

The Angular template's dependencies were straightforward to update.

The React template's updated dependencies had a lot of breaking changes, so a fair amount of JavaScript had to be updated/rewritten. The primary refactoring involved routing and authentication. I also fixed formatting issues here and there (e.g., changed files that were using 4-space indentation to instead use 2-space indentation).

Validation

Manually tested both templates with and without individual authentication.

@MackinnonBuck MackinnonBuck requested a review from wtgodbe May 2, 2022 21:55
@MackinnonBuck
Copy link
Member Author

Also validated published builds on Windows and macOS.

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Looks great!

@MackinnonBuck MackinnonBuck merged commit e357a5f into main May 3, 2022
@MackinnonBuck MackinnonBuck deleted the mbuck/update-js-dependencies branch May 3, 2022 15:46
@mkArtakMSFT
Copy link
Member

@MackinnonBuck are you also taking care of updating the submodule in dotnet/aspnetcore repo to pull this change in for 6.0?

@MackinnonBuck
Copy link
Member Author

@mkArtakMSFT sure, I'll handle that as well

@wtgodbe
Copy link
Member

wtgodbe commented May 3, 2022

@MackinnonBuck are you also taking care of updating the submodule in dotnet/aspnetcore repo to pull this change in for 6.0?

This is the main branch, we'd need to backport this to https://github.com/dotnet/spa-templates/tree/release/6.0 to get it in to aspnetcore's release/6.0 branch

@wtgodbe
Copy link
Member

wtgodbe commented May 3, 2022

For main, I'm going to get this in to dotnet/aspnetcore#41485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants