Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request #918, expose Spark version info #919

Merged
merged 13 commits into from Jun 4, 2021
Merged

Feature Request #918, expose Spark version info #919

merged 13 commits into from Jun 4, 2021

Conversation

alvaromuir
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@dnfadmin
Copy link

dnfadmin commented Apr 18, 2021 •
edited

CLA assistant check
All CLA requirements met.

@alvaromuir alvaromuir mentioned this pull request Apr 18, 2021
Closed
suhsteve
suhsteve reviewed Apr 19, 2021
View reviewed changes
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
@suhsteve
Copy link
Member

@alvaromuir looks like the merge conflict wasn't merged correctly. Can you fix it ?

imback82
imback82 reviewed Apr 24, 2021
View reviewed changes
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated
@@ -23,6 +23,7 @@ public sealed class SparkSession : IDisposable, IJvmObjectReferenceProvider

private readonly Lazy<SparkContext> _sparkContext;
private readonly Lazy<Catalog.Catalog> _catalog;
private readonly string _version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

src/csharp/Microsoft.Spark/Sql/SparkSession.cs Show resolved Hide resolved
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
suhsteve
suhsteve reviewed May 4, 2021
View reviewed changes
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, but LGTM. Thanks @alvaromuir

src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/SparkContext.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
@imback82 imback82 added this to the 2.0.0 milestone Jun 1, 2021
suhsteve
suhsteve approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @alvaromuir !

imback82
imback82 approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alvaromuir!

@imback82 imback82 merged commit 4ede264 into dotnet:main Jun 4, 2021
@imback82 imback82 mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhsteve suhsteve suhsteve approved these changes

@imback82 imback82 imback82 approved these changes

@Niharikadutta Niharikadutta Awaiting requested review from Niharikadutta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alvaromuir @dnfadmin @suhsteve @imback82