Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Trimming package should be removed from dotnet/standard repo #788

Closed
ericstj opened this issue Jul 2, 2018 · 4 comments
Closed

Trimming package should be removed from dotnet/standard repo #788

ericstj opened this issue Jul 2, 2018 · 4 comments
Assignees
Labels
packaging Applied to issues with NuGet packages. tools

Comments

@ericstj
Copy link
Member

ericstj commented Jul 2, 2018

There's really no good reason for this package to live in the standard repo.

A few suggestions for a new home:

  1. CoreFxLab
  2. Its own repo under dotnet
  3. Its own repo under ericstj, since I'm the sole contributor. I'd change the name of the package if I did this.

The downside of lab is that it implies an experiment and never has "releases" however I'd actually like to push towards a stable release of this tool.

@weshaggard @Petermarcu @terrajobst do any of you have an opinion?

@ericstj ericstj self-assigned this Jul 2, 2018
@ericstj ericstj added packaging Applied to issues with NuGet packages. tools labels Jul 2, 2018
@weshaggard
Copy link
Member

weshaggard commented Jul 2, 2018

I agree it doesn't really belong in the standard repo and I agree that corefxlab doesn't really fit either. I suggest a repo under your account until a time it becomes something we want to ship as part of the product.

@terrajobst
Copy link
Member

Agreed

@ericstj
Copy link
Member Author

ericstj commented Oct 1, 2018

I'll also point folks at the official Linker (https://github.com/dotnet/core/blob/master/samples/linker-instructions.md) along with a compare/contrast the two projects.

@ericstj ericstj changed the title Trimming package Trimming package should be removed from dotnet/standard repo Dec 6, 2018
ericstj added a commit to ericstj/standard that referenced this issue Dec 6, 2018
@ericstj
Copy link
Member Author

ericstj commented Dec 6, 2018

Those looking for an officially supported trimming tool should try:
https://github.com/dotnet/core/blob/master/samples/linker-instructions.md

The assembly level linker has moved to:
https://github.com/ericstj/Microsoft.Packaging.Tools.Trimming

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
packaging Applied to issues with NuGet packages. tools
Projects
None yet
Development

No branches or pull requests

3 participants