Update shims #121
Update shims #121
Conversation
|
Oh, you only touched 233 files. That should be a fast review then ;-) |
|
It seems commit a3ca396 misses |
weshaggard
force-pushed
the
UpdateShims
branch
from
399b811
to
e7e235f
Compare
|
netstandard1.6.shims.txt is helpful to look at, but github thinks it's binary for some reason. Am I correct in thinking that this is the full list of System.Runtime-based contracts that's getting absorbed by netstandard? Surprised to see System.Data.* in here but I understand why. Where are the baselines that show what types are missing from netstandard.dll but were already shipped in ns1.6 refs? |
|
@ericstj This branch is in bad state I'm going to try and clean it up and once I do I will ping you guys for review. The netstandard1.6.shims.txt file contains any assembly that we shipped as a package with a netstandard1.6 compatible asset (i.e. could be older netstandard version as well). |
|
|
The netstandard.shimlist.txt was generated by taking all the packages that we shipped as part of .NET Core 1.1: https://github.com/dotnet/versions/blob/master/build-info/dotnet/corefx/release/1.1.0/LKG_Packages.txt Restoring all of them for netstandard1.6 and taking any assemblies that contain any types that are in netstandard.dll.
This filters the list of type forwards in the compat shims to only include types that are included in netstandard2.0.
The netfx.shimlist.txt file contains a subset of the .NET Framework 4.6.1 assemblies that contain any types that are part of .NET Standard 2.0 that we need compat shims for. The shims only contain type forwards for the set of types that live in netstandard.dll.
weshaggard
force-pushed
the
UpdateShims
branch
from
ea2287a
to
931d6c5
Compare
|
OK I've updated this shim set. Please have a look at the changes commit by commit for easier reviewing. |
netstandard based shims go under: build\netstandard2.0\ref build\net461\ref netfx based shims go under: build\netstandard2.0\ref netstandard facades built against netfx goes under: build\net461\ref
weshaggard
force-pushed
the
UpdateShims
branch
from
931d6c5
to
267afac
Compare
cc @ericstj @terrajobst
Here is a PR for the shim updates that I want to chat about tomorrow.