This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Add ISOWeek #963
Merged
Add ISOWeek #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarekgh, any concerns adding this type to .NET Standard? |
|
I'd need to double check the naming guidelines, but shouldn't it be IsoWeek instead of ISOWeek? |
|
@jskeet This was noted in the API review (and a couple of times since as well) and ended up being caps; https://github.com/dotnet/corefx/issues/28933#issuecomment-392873426 |
marek-safar
approved these changes
Nov 8, 2018
stephentoub
approved these changes
Nov 8, 2018
joshpeterson
approved these changes
Nov 8, 2018
jkotas
approved these changes
Nov 8, 2018
jskeet
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
I'm biased towards using the term WeekYear (and weekYear for parameters etc) to make it really, really clear that it's not the normal calendrical year (e.g. if GetYearStart returns a value with a different year to the year argument) but hopefully it's obvious enough from the class name.
tarekgh
approved these changes
Nov 8, 2018
jaredpar
approved these changes
Nov 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #956