New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync .NET Standard's RefEmit with .NET Framework #999

Merged
merged 8 commits into from Dec 12, 2018

Conversation

@terrajobst
Member

terrajobst commented Dec 6, 2018

Fixes #987

The point of the sync is to get increase parity with .NET Framework and thus making it easier to port more existing code to .NET Standard 2.1 (or any platform implementing it).

@terrajobst terrajobst requested review from dotnet/nsboard-foundation as code owners Dec 6, 2018

@terrajobst terrajobst added this to the .NET Standard 2.1 milestone Dec 6, 2018

Show resolved Hide resolved netstandard/ref/System.Reflection.Emit.cs Outdated
Show resolved Hide resolved netstandard/ref/System.Reflection.Emit.cs Outdated
Show resolved Hide resolved netstandard/ref/System.Reflection.Emit.cs Outdated

@terrajobst terrajobst changed the title from Syncs .NET Standard's RefEmit with .NET Framework to Sync .NET Standard's RefEmit with .NET Framework Dec 6, 2018

@terrajobst terrajobst force-pushed the terrajobst:reflection-update branch 2 times, most recently from 728ae53 to 142b5dd Dec 6, 2018

@jkotas

jkotas approved these changes Dec 7, 2018

@jkotas

This comment has been minimized.

Member

jkotas commented Dec 7, 2018

I assume that you will get work items scheduled to get the various one-offs added to .NET Core 3.0.

We have dotnet/corefx#12055 for DynamicILInfo already. DynamicILInfo is the most important of all these since it adds back capability that is very hard to workaround.

@terrajobst

This comment has been minimized.

Member

terrajobst commented Dec 7, 2018

I assume that you will get work items scheduled to get the various one-offs added to .NET Core 3.0.

Yep. I'm planning to do one more diff between .NET Standard 2.1 and .NET Core 3.0. This will catch other APIs we should be adding to .NET Standard and will also show us the things we need to add for .NET Core 3.0. The work will be tracked here.

@terrajobst

This comment has been minimized.

Member

terrajobst commented Dec 11, 2018

@marek-safar, did we address your concerns?

terrajobst added some commits Dec 12, 2018

terrajobst added some commits Dec 6, 2018

Expose CreateMethodBody()
There are other APIs that accept arrays and lengths and these don't have
alternatives. For consistency and for more compatible let's simply expose
CreateMethodBody() as-is.

@terrajobst terrajobst force-pushed the terrajobst:reflection-update branch from 76364b0 to 6454b1b Dec 12, 2018

@terrajobst

This comment has been minimized.

Member

terrajobst commented Dec 12, 2018

Hey @onovotny / @jskeet, any concerns here?
@jaredpar?

@terrajobst terrajobst merged commit 17bb580 into dotnet:master Dec 12, 2018

5 checks passed

OSX10.12 Build finished.
Details
Ubuntu16.04 Build finished.
Details
Windows_NT Build finished.
Details
license/cla All CLA requirements met.
Details
standard-ci #20181212.4 succeeded
Details

@terrajobst terrajobst deleted the terrajobst:reflection-update branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment