This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Sync .NET Standard's RefEmit with .NET Framework #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrajobst
commented
Dec 6, 2018
terrajobst
changed the title
jkotas
reviewed
Dec 6, 2018
jkotas
reviewed
Dec 6, 2018
jkotas
reviewed
Dec 6, 2018
jkotas
reviewed
Dec 6, 2018
marek-safar
suggested changes
Dec 6, 2018
jkotas
reviewed
Dec 6, 2018
jkotas
reviewed
Dec 6, 2018
jkotas
reviewed
Dec 6, 2018
terrajobst
force-pushed
the
reflection-update
branch
2 times, most recently
from
728ae53
to
142b5dd
Compare
joshpeterson
approved these changes
Dec 7, 2018
jkotas
approved these changes
Dec 7, 2018
|
I assume that you will get work items scheduled to get the various one-offs added to .NET Core 3.0. We have https://github.com/dotnet/corefx/issues/12055 for |
jkotas
reviewed
Dec 7, 2018
Yep. I'm planning to do one more diff between .NET Standard 2.1 and .NET Core 3.0. This will catch other APIs we should be adding to .NET Standard and will also show us the things we need to add for .NET Core 3.0. The work will be tracked here. |
|
@marek-safar, did we address your concerns? |
marek-safar
approved these changes
Dec 12, 2018
There are other APIs that accept arrays and lengths and these don't have alternatives. For consistency and for more compatible let's simply expose CreateMethodBody() as-is.
terrajobst
force-pushed
the
reflection-update
branch
from
76364b0
to
6454b1b
Compare
clairernovotny
approved these changes
Dec 12, 2018
jaredpar
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #987
The point of the sync is to get increase parity with .NET Framework and thus making it easier to port more existing code to .NET Standard 2.1 (or any platform implementing it).