Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix choices not being honored for C# classlibs #2335

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix choices not being honored for C# classlibs #2335

merged 1 commit into from
Mar 25, 2020

Conversation

ViktorHofer
Copy link
Member

cc @grinrag

ViktorHofer added a commit that referenced this pull request Mar 24, 2020
@ViktorHofer
Fix choices not being honored for C# classlibs
5ad224f 
Manual port of #2335
@ViktorHofer ViktorHofer mentioned this pull request Mar 24, 2020
Merged
ViktorHofer added a commit that referenced this pull request Mar 24, 2020
@ViktorHofer
Fix choices not being honored for C# classlibs (#2336)
7e732bc 
Manual port of #2335
genalt
genalt approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@genalt genalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer ViktorHofer merged commit 790193e into master Mar 25, 2020
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch March 25, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genalt genalt genalt approved these changes

@donJoseLuis donJoseLuis donJoseLuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ViktorHofer @genalt @donJoseLuis