more auto properties

src/Microsoft.TemplateEngine.Core/Operations/BalancedNesting.cs

@@ -22,7 +22,6 @@ public class BalancedNesting : IOperationProvider
         private readonly ITokenConfig _startToken;
         private readonly ITokenConfig _realEndToken;
         private readonly ITokenConfig _pseudoEndToken;
-        private readonly string? _id;
         private readonly string? _resetFlag;
         private readonly bool _initialState;
 
@@ -31,20 +30,20 @@ public BalancedNesting(ITokenConfig startToken, ITokenConfig realEndToken, IToke
             _startToken = startToken;
             _realEndToken = realEndToken;
             _pseudoEndToken = pseudoEndToken;
-            _id = id;
+            Id = id;
             _resetFlag = resetFlag;
             _initialState = initialState;
         }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public IOperation GetOperation(Encoding encoding, IProcessorState processorState)
         {
             IToken startToken = _startToken.ToToken(encoding);
             IToken realEndToken = _realEndToken.ToToken(encoding);
             IToken pseudoEndToken = _pseudoEndToken.ToToken(encoding);
 
-            return new Implementation(startToken, realEndToken, pseudoEndToken, _id, _resetFlag, _initialState);
+            return new Implementation(startToken, realEndToken, pseudoEndToken, Id, _resetFlag, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Core/Operations/Conditional.cs

@@ -128,19 +128,18 @@ private class Implementation : IOperation
             private readonly Conditional _definition;
             private readonly Stack<EvaluationState> _pendingCompletion = new Stack<EvaluationState>();
             private readonly ITokenTrie _trie;
-            private readonly string? _id;
             private EvaluationState? _current;
 
             public Implementation(Conditional definition, IReadOnlyList<IToken> tokens, ITokenTrie trie, string? id, bool initialState)
             {
                 _trie = trie;
                 _definition = definition;
                 Tokens = tokens;
-                _id = id;
+                Id = id;
                 IsInitialStateOn = string.IsNullOrEmpty(id) || initialState;
             }
 
-            public string? Id => _id;
+            public string? Id { get; }
 
             public IReadOnlyList<IToken> Tokens { get; }
 

src/Microsoft.TemplateEngine.Core/Operations/ExpandVariables.cs

@@ -10,20 +10,19 @@ public class ExpandVariables : IOperationProvider
     {
         public static readonly string OperationName = "expandvariables";
 
-        private readonly string? _id;
         private readonly bool _initialState;
 
         public ExpandVariables(string? id, bool initialState)
         {
-            _id = id;
+            Id = id;
             _initialState = initialState;
         }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public IOperation GetOperation(Encoding encoding, IProcessorState processor)
         {
-            return new Implementation(processor, _id, _initialState);
+            return new Implementation(processor, Id, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Core/Operations/Include.cs

@@ -11,16 +11,14 @@ public class Include : IOperationProvider
     {
         public static readonly string OperationName = "include";
 
-        private readonly string? _id;
-
         private readonly bool _initialState;
 
         public Include(ITokenConfig startToken, ITokenConfig endToken, Func<string, Stream?> sourceStreamOpener, string? id, bool initialState)
         {
             SourceStreamOpener = sourceStreamOpener;
             StartToken = startToken;
             EndToken = endToken;
-            _id = id;
+            Id = id;
             _initialState = initialState;
         }
 
@@ -30,15 +28,15 @@ public Include(ITokenConfig startToken, ITokenConfig endToken, Func<string, Stre
 
         public Func<string, Stream?> SourceStreamOpener { get; }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public IOperation GetOperation(Encoding encoding, IProcessorState processorState)
         {
             IToken tokenBytes = StartToken.ToToken(encoding);
             IToken endTokenBytes = EndToken.ToToken(encoding);
             TokenTrie endTokenMatcher = new TokenTrie();
             endTokenMatcher.AddToken(endTokenBytes);
-            return new Implementation(tokenBytes, endTokenMatcher, this, _id, _initialState);
+            return new Implementation(tokenBytes, endTokenMatcher, this, Id, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Core/Operations/InlineMarkupConditional.cs

@@ -9,13 +9,12 @@ namespace Microsoft.TemplateEngine.Core.Operations
 {
     public class InlineMarkupConditional : IOperationProvider
     {
-        private readonly string? _id;
         private readonly bool _initialState;
 
         public InlineMarkupConditional(MarkupTokens tokens, bool wholeLine, bool trimWhitespace, ConditionEvaluator evaluator, string variableFormat, string? id, bool initialState)
         {
             Tokens = tokens;
-            _id = id;
+            Id = id;
             Evaluator = evaluator;
             WholeLine = wholeLine;
             TrimWhitespace = trimWhitespace;
@@ -25,7 +24,7 @@ public InlineMarkupConditional(MarkupTokens tokens, bool wholeLine, bool trimWhi
 
         public ConditionEvaluator Evaluator { get; }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public MarkupTokens Tokens { get; }
 
@@ -65,7 +64,7 @@ public IOperation GetOperation(Encoding encoding, IProcessorState processorState
                 closeCommentToken);
 
             IReadOnlyList<IToken> start = new[] { Tokens.OpenConditionExpression.ToToken(processorState.Encoding) };
-            return new Implementation(this, start, structureTrie, closeConditionTrie, scanBackTrie, mapping, _id, _initialState);
+            return new Implementation(this, start, structureTrie, closeConditionTrie, scanBackTrie, mapping, Id, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Core/Operations/PhasedOperation.cs

@@ -9,17 +9,16 @@ namespace Microsoft.TemplateEngine.Core.Operations
     public class PhasedOperation : IOperationProvider
     {
         private readonly IReadOnlyList<Phase> _config;
-        private readonly string? _id;
         private readonly bool _initialState;
 
         public PhasedOperation(string? id, IReadOnlyList<Phase> config, bool initialState)
         {
-            _id = id;
+            Id = id;
             _config = config;
             _initialState = initialState;
         }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public IOperation GetOperation(Encoding encoding, IProcessorState processorState)
         {
@@ -98,10 +97,10 @@ public Implementation(PhasedOperation definition, IReadOnlyList<IToken> config,
                 _definition = definition;
                 Tokens = config;
                 _entryPoints = entryPoints;
-                IsInitialStateOn = string.IsNullOrEmpty(_definition._id) || initialState;
+                IsInitialStateOn = string.IsNullOrEmpty(_definition.Id) || initialState;
             }
 
-            public string? Id => _definition._id;
+            public string? Id => _definition.Id;
 
             public IReadOnlyList<IToken> Tokens { get; }
 

src/Microsoft.TemplateEngine.Core/Operations/Region.cs

@@ -16,7 +16,6 @@ public class Region : IOperationProvider
         private readonly bool _toggle;
         private readonly bool _wholeLine;
         private readonly bool _trimWhitespace;
-        private readonly string? _id;
         private readonly bool _initialState;
 
         public Region(ITokenConfig start, ITokenConfig end, bool include, bool wholeLine, bool trimWhitespace, string? id, bool initialState)
@@ -27,17 +26,17 @@ public Region(ITokenConfig start, ITokenConfig end, bool include, bool wholeLine
             _end = end;
             _include = include;
             _toggle = _start.Equals(_end);
-            _id = id;
+            Id = id;
             _initialState = initialState;
         }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public IOperation GetOperation(Encoding encoding, IProcessorState processorState)
         {
             IToken startToken = _start.ToToken(encoding);
             IToken endToken = _end.ToToken(encoding);
-            return new Implementation(this, startToken, endToken, _include, _toggle, _id, _initialState);
+            return new Implementation(this, startToken, endToken, _include, _toggle, Id, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Core/Operations/Replacement.cs

@@ -12,18 +12,17 @@ public class Replacement : IOperationProvider
 
         private readonly ITokenConfig _match;
         private readonly string? _replaceWith;
-        private readonly string? _id;
         private readonly bool _initialState;
 
         public Replacement(ITokenConfig match, string? replaceWith, string? id, bool initialState)
         {
             _match = match;
             _replaceWith = replaceWith;
-            _id = id;
+            Id = id;
             _initialState = initialState;
         }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public IOperation GetOperation(Encoding encoding, IProcessorState processorState)
         {
@@ -35,7 +34,7 @@ public IOperation GetOperation(Encoding encoding, IProcessorState processorState
                 return null!;
             }
 
-            return new Implementation(token, replaceWith, _id, _initialState);
+            return new Implementation(token, replaceWith, Id, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Core/Operations/SetFlag.cs

@@ -10,7 +10,6 @@ public class SetFlag : IOperationProvider
     {
         public static readonly string OperationName = "flags";
 
-        private readonly string? _id;
         private readonly bool _initialState;
 
         public SetFlag(string? name, ITokenConfig on, ITokenConfig off, ITokenConfig onNoEmit, ITokenConfig offNoEmit, string? id, bool initialState, bool? @default = null)
@@ -21,11 +20,11 @@ public SetFlag(string? name, ITokenConfig on, ITokenConfig off, ITokenConfig onN
             OnNoEmit = onNoEmit;
             OffNoEmit = offNoEmit;
             Default = @default;
-            _id = id;
+            Id = id;
             _initialState = initialState;
         }
 
-        public string? Id => _id;
+        public string? Id { get; }
 
         public string? Name { get; }
 
@@ -54,7 +53,7 @@ public IOperation GetOperation(Encoding encoding, IProcessorState processorState
                 processorState.Config.Flags[Name!] = Default.Value;
             }
 
-            return new Implementation(this, tokens, _id, _initialState);
+            return new Implementation(this, tokens, Id, _initialState);
         }
 
         private class Implementation : IOperation

src/Microsoft.TemplateEngine.Edge/DefaultTemplateEngineHost.cs

@@ -14,8 +14,6 @@ public class DefaultTemplateEngineHost : ITemplateEngineHost
         private static readonly IReadOnlyList<(Type, IIdentifiedComponent)> NoComponents = Array.Empty<(Type, IIdentifiedComponent)>();
         private readonly IReadOnlyDictionary<string, string> _hostDefaults;
         private readonly IReadOnlyList<(Type InterfaceType, IIdentifiedComponent Instance)> _hostBuiltInComponents;
-        private readonly ILoggerFactory _loggerFactory;
-        private readonly ILogger _logger;
 
         public DefaultTemplateEngineHost(
             string hostIdentifier,
@@ -33,8 +31,8 @@ public class DefaultTemplateEngineHost : ITemplateEngineHost
             FallbackHostTemplateConfigNames = fallbackHostTemplateConfigNames ?? new List<string>();
 
             loggerFactory ??= NullLoggerFactory.Instance;
-            _loggerFactory = loggerFactory;
-            _logger = _loggerFactory.CreateLogger("Template Engine") ?? NullLogger.Instance;
+            LoggerFactory = loggerFactory;
+            Logger = LoggerFactory.CreateLogger("Template Engine") ?? NullLogger.Instance;
 
             WorkingDirectory = Environment.CurrentDirectory;
         }
@@ -51,9 +49,9 @@ public class DefaultTemplateEngineHost : ITemplateEngineHost
 
         public virtual IReadOnlyList<(Type InterfaceType, IIdentifiedComponent Instance)> BuiltInComponents => _hostBuiltInComponents;
 
-        public ILogger Logger => _logger;
+        public ILogger Logger { get; }
 
-        public ILoggerFactory LoggerFactory => _loggerFactory;
+        public ILoggerFactory LoggerFactory { get; }
 
         // stub that will be built out soon.
         public virtual bool TryGetHostParamDefault(string paramName, out string? value)
@@ -78,7 +76,7 @@ public void VirtualizeDirectory(string path)
 
         public void Dispose()
         {
-            _loggerFactory?.Dispose();
+            LoggerFactory?.Dispose();
         }
 
         #region Obsoleted

src/Microsoft.TemplateEngine.Edge/Template/ParameterSetBuilder.cs

@@ -346,9 +346,6 @@ private void EvaluateConditionalParameters(IGenerator generator, ILogger logger)
 
         private class EvalData
         {
-            private object? _value;
-            private DataSource _dataSource = DataSource.NoSource;
-
             public EvalData(ITemplateParameter parameterDefinition)
             {
                 ParameterDefinition = parameterDefinition;
@@ -357,7 +354,7 @@ public EvalData(ITemplateParameter parameterDefinition)
             public EvalData(EvaluatedInputParameterData other)
                 : this(other.ParameterDefinition, other.Value, other.IsEnabledConditionResult, other.IsRequiredConditionResult)
             {
-                this._dataSource = DataSource.NoSource;
+                this.DataSource = DataSource.NoSource;
             }
 
             private EvalData(
@@ -367,7 +364,7 @@ public EvalData(EvaluatedInputParameterData other)
                 bool? isRequiredConditionResult)
             {
                 ParameterDefinition = parameterDefinition;
-                _value = value;
+                Value = value;
                 IsEnabledConditionResult = isEnabledConditionResult;
                 IsRequiredConditionResult = isRequiredConditionResult;
             }
@@ -380,14 +377,14 @@ public EvalData(EvaluatedInputParameterData other)
 
             public bool? IsRequiredConditionResult { get; set; }
 
-            public DataSource DataSource => _dataSource;
+            public DataSource DataSource { get; private set; } = DataSource.NoSource;
 
-            public object? Value => _value;
+            public object? Value { get; private set; }
 
             public void SetValue(object? value, DataSource source)
             {
-                _value = value;
-                _dataSource = source;
+                Value = value;
+                DataSource = source;
                 InputDataState = InputDataStateUtil.GetInputDataState(value);
             }
 
@@ -398,18 +395,18 @@ public EvaluatedInputParameterData ToParameterData()
                 return new EvaluatedInputParameterData(
                     this.ParameterDefinition,
                     this.Value,
-                    _dataSource,
+                    DataSource,
                     this.IsEnabledConditionResult,
                     this.IsRequiredConditionResult,
                     InputDataState);
             }
 
             public EvalData Clone()
             {
-                var ds = _dataSource;
+                var ds = DataSource;
                 return new EvalData(ParameterDefinition, Value, IsEnabledConditionResult, IsRequiredConditionResult)
                 {
-                    _dataSource = ds
+                    DataSource = ds
                 };
             }
 

src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/RunnableProjectConfig.ITemplate.cs

@@ -19,11 +19,11 @@ internal partial class RunnableProjectConfig : ITemplate
 
         string ITemplateLocator.ConfigPlace => ConfigFile?.FullPath ?? throw new InvalidOperationException("Configuration file is not initialized, are you using test constructor?");
 
-        IFileSystemInfo? ITemplate.LocaleConfiguration => _localizationInfo?.File;
+        IFileSystemInfo? ITemplate.LocaleConfiguration => Localization?.File;
 
         IFileSystemInfo? ITemplate.HostSpecificConfiguration => _hostConfigFile;
 
-        string? IExtendedTemplateLocator.LocaleConfigPlace => _localizationInfo?.File.FullPath;
+        string? IExtendedTemplateLocator.LocaleConfigPlace => Localization?.File.FullPath;
 
         string? IExtendedTemplateLocator.HostConfigPlace => _hostConfigFile?.FullPath;