Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle imports better and fix some bugs #314

Merged
merged 1 commit into from Oct 13, 2020
Merged

Handle imports better and fix some bugs #314

merged 1 commit into from Oct 13, 2020

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Oct 12, 2020 •
edited

fixes #313 and fixes #295

Looks like this

image

@cartermp cartermp requested a review from jmarolf October 12, 2020 20:04
jmarolf
jmarolf approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cartermp
Copy link
Contributor Author

I will do a separate pass to change is { } to is not null so that you don't violently shake every time you see my beautiful code

@cartermp cartermp merged commit f80461c into dotnet:master Oct 13, 2020
@cartermp cartermp deleted the imports-and-fixes branch October 13, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cartermp @jmarolf