Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

[main] Update dependencies from dotnet/arcade #1008

Merged
merged 39 commits into from
May 3, 2021
Merged

[main] Update dependencies from dotnet/arcade #1008

merged 39 commits into from
May 3, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 10, 2021 •
edited

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: e2439efc-bcfc-40b3-0e82-08d8e40a189f
  • Build: 20210430.2
  • Date Produced: 4/30/2021 11:17 PM
  • Commit: 46ad27d3cc557f2b84ce30b2c4e27438526dc91d
  • Branch: refs/heads/main

@jkotalik jkotalik self-assigned this Apr 22, 2021
@jkotalik
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JunTaoLuo
Copy link

JunTaoLuo commented Apr 28, 2021 •
edited

Current theory is that the new SDK (preview2) has new MSBuild tasks/targets that uses 5.0.0 APIs. When the MSBuild locator resolves the SDK, it picks the SDK specified in the global.json. However, given the projects are targeting 3.1 runtime and loads 3.1 assemblies, the MSBuild tasks, when invoked, causes the assembly load failure.

@jkotalik
Copy link
Contributor

This solution removes all need for msbuild in process, but source copies a few things from the msbuild repo (aka everything needed for solution file parsing). It's around 2.5k LoC, if we aren't okay with that we can try investigating calling this out of proc with dotnet msbuild.

@jkotalik jkotalik mentioned this pull request Apr 30, 2021
Open
@jkotalik
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotalik
Copy link
Contributor

I'm seeing this pass locally, going to check why things are timing out on CI.

dotnet-maestro bot and others added 17 commits May 3, 2021 09:14
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
5f3f298 
…405.1

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21205.1
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
81724e5 
…407.4

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21205.1 -> To Version 6.0.0-beta.21207.4
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
bd096ca 
…408.2

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21207.4 -> To Version 6.0.0-beta.21208.2
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
40c3619 
…409.17

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21209.17
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
ebd3b80 
…412.6

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21212.6
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
431223c 
…414.5

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21214.5
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
22f5e1c 
…415.5

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21215.5
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
3c65ce9 
…416.2

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21216.2
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
303438c 
…419.2

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21219.2
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
5909654 
…420.2

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21220.2
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
4bb059a 
…421.1

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21221.1
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
d4212f3 
…422.1

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21222.1
@jkotalik
Revert SDK update
338328a
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
a05ba31 
…428.3

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21228.3
@jkotalik
bye bye msbuild
f8c6396
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
1c9a117 
…429.1

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21229.1
@jkotalik
Moving files and ignoring warnings
c58dc2a
jkotalik and others added 3 commits May 3, 2021 09:14
@jkotalik
format
58a74de
@dotnet-maestro @jkotalik
Update dependencies from https://github.com/dotnet/arcade build 20210…
4bbdb87 
…430.2

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 6.0.0-beta.21160.1 -> To Version 6.0.0-beta.21230.2
@jkotalik
tests
fe06d86
@jkotalik jkotalik force-pushed the darc-main-d78d5181-5593-419e-96cc-ddf962cf20f8 branch from 7653838 to fe06d86 Compare May 3, 2021 16:15
@jkotalik
Copy link
Contributor

jkotalik commented May 3, 2021

Something is up with the SDK that is causing dotnet build to hang indefinitely:


Executing application from "/tmp/bjkusnfi.gtf/tye.yaml"
Dashboard running on "http://127.0.0.1:8000"
Building projects
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview

And that's it. No other output from dotnet build.

@jkotalik
Copy link
Contributor

jkotalik commented May 3, 2021

I can repro this locally on ubuntu, but this doesn't repro when running dotnet test on commandline OR when invoking the same command that is being invoked for dotnet build. Only when invoking the build.sh -test. So weird.

@jkotalik
Copy link
Contributor

jkotalik commented May 3, 2021

Skipping tests on osx and linux for now. Will file a follow up issue accordingly.

JunTaoLuo
JunTaoLuo approved these changes May 3, 2021
View reviewed changes
Copy link

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I didn't find any way to fix the issue without bringing in all the MSBuild sources. But let's file an issue to track reviewing whether we can find an alternative before a rtm release.

@dotnet-maestro dotnet-maestro bot merged commit e6b6b06 into main May 3, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-d78d5181-5593-419e-96cc-ddf962cf20f8 branch May 3, 2021 23:15
@JunTaoLuo JunTaoLuo mentioned this pull request May 4, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

@jkotalik jkotalik Awaiting requested review from jkotalik

@rynowak rynowak Awaiting requested review from rynowak

Assignees

@jkotalik jkotalik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkotalik @JunTaoLuo