define docker baseimage and tag #447
Conversation
| @@ -268,6 +268,10 @@ private static void EvaluateProject(OutputContext output, ProjectServiceBuilder | |||
| project.Frameworks.AddRange(sharedFrameworks.Select(s => new Framework(s))); | |||
| output.WriteDebugLine($"Found shared frameworks: {string.Join(", ", sharedFrameworks)}"); | |||
|
|
|||
| // determine container base image | |||
| project.ContainerInfo!.BaseImageName = projectInstance.GetPropertyValue("ContainerBaseImage"); | |||
There was a problem hiding this comment.
I think having a null check here for project.ContainerInfo is probably better.
There was a problem hiding this comment.
Need the property here, should I create it?
new ContainerInfo() { UseMultiphaseDockerfile = false, };
| @@ -268,6 +268,15 @@ private static void EvaluateProject(OutputContext output, ProjectServiceBuilder | |||
| project.Frameworks.AddRange(sharedFrameworks.Select(s => new Framework(s))); | |||
| output.WriteDebugLine($"Found shared frameworks: {string.Join(", ", sharedFrameworks)}"); | |||
|
|
|||
| // determine container base image | |||
| if (project.ContainerInfo == null) | |||
There was a problem hiding this comment.
See @jkotalik comment : #447 (comment)
There was a problem hiding this comment.
There was a problem hiding this comment.
@davidfowl I agree and it appears that it is the only entry point. However, @jkotalik is suggesting that there should be a null check, if it is (although it shoudn't be) we must create the instance.
previously I was just setting the values - project.ContainerInfo!.BaseImageName
spboyer
changed the title
|
I had a bunch of small nits, I just went ahead and committed them to the branch |
Fixes #240